Skip to content

Commit

Permalink
fix(x/group): proper address rendering in error (#22425)
Browse files Browse the repository at this point in the history
(cherry picked from commit 8c24b6b)

# Conflicts:
#	x/group/keeper/proposal_executor.go
  • Loading branch information
julienrbrt authored and mergify[bot] committed Nov 5, 2024
1 parent 751e5ec commit bcccdc5
Showing 1 changed file with 14 additions and 0 deletions.
14 changes: 14 additions & 0 deletions x/group/keeper/proposal_executor.go
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,21 @@ func ensureMsgAuthZ(msgs []sdk.Msg, groupPolicyAcc sdk.AccAddress, cdc codec.Cod

for _, acct := range signers {
if !bytes.Equal(groupPolicyAcc, acct) {
<<<<<<< HEAD

Check failure on line 79 in x/group/keeper/proposal_executor.go

View workflow job for this annotation

GitHub Actions / dependency-review

expected statement, found '<<'

Check failure on line 79 in x/group/keeper/proposal_executor.go

View workflow job for this annotation

GitHub Actions / tests (03)

syntax error: unexpected <<, expected }

Check failure on line 79 in x/group/keeper/proposal_executor.go

View workflow job for this annotation

GitHub Actions / tests (03)

syntax error: unexpected <<, expected }
return errorsmod.Wrapf(sdkerrors.ErrUnauthorized, "msg does not have group policy authorization; expected %s, got %s", groupPolicyAcc.String(), acct)
=======

Check failure on line 81 in x/group/keeper/proposal_executor.go

View workflow job for this annotation

GitHub Actions / dependency-review

expected statement, found '=='

Check failure on line 81 in x/group/keeper/proposal_executor.go

View workflow job for this annotation

GitHub Actions / tests (03)

syntax error: unexpected ==, expected }

Check failure on line 81 in x/group/keeper/proposal_executor.go

View workflow job for this annotation

GitHub Actions / tests (03)

syntax error: unexpected ==, expected }
groupPolicyAddr, err := addressCodec.BytesToString(groupPolicyAcc)
if err != nil {
return errorsmod.Wrapf(sdkerrors.ErrUnauthorized, "msg does not have group policy authorization; error retrieving group policy address")
}

acctStr, _ := addressCodec.BytesToString(acct)
if acctStr == "" {
acctStr = "unmarshalable address"
}

return errorsmod.Wrapf(sdkerrors.ErrUnauthorized, "msg does not have group policy authorization; expected %s, got %s", groupPolicyAddr, acctStr)
>>>>>>> 8c24b6bef (fix(x/group): proper address rendering in error (#22425))

Check failure on line 93 in x/group/keeper/proposal_executor.go

View workflow job for this annotation

GitHub Actions / dependency-review

expected statement, found '>>'

Check failure on line 93 in x/group/keeper/proposal_executor.go

View workflow job for this annotation

GitHub Actions / dependency-review

illegal character U+0023 '#'

Check failure on line 93 in x/group/keeper/proposal_executor.go

View workflow job for this annotation

GitHub Actions / tests (03)

syntax error: unexpected >>, expected }

Check failure on line 93 in x/group/keeper/proposal_executor.go

View workflow job for this annotation

GitHub Actions / tests (03)

invalid character U+0023 '#'

Check failure on line 93 in x/group/keeper/proposal_executor.go

View workflow job for this annotation

GitHub Actions / tests (03)

syntax error: unexpected >>, expected }

Check failure on line 93 in x/group/keeper/proposal_executor.go

View workflow job for this annotation

GitHub Actions / tests (03)

invalid character U+0023 '#'
}
}

Check failure on line 95 in x/group/keeper/proposal_executor.go

View workflow job for this annotation

GitHub Actions / tests (03)

syntax error: non-declaration statement outside function body

Check failure on line 95 in x/group/keeper/proposal_executor.go

View workflow job for this annotation

GitHub Actions / tests (03)

syntax error: non-declaration statement outside function body
}
Expand Down

0 comments on commit bcccdc5

Please sign in to comment.