fix(x/slashing): consensus failure after cons key rotation (#19038)

cosmos · Jan 12, 2024 · eaf92c2 · eaf92c2
1 parent b98b6eb
commit eaf92c2
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 3 deletions.
diff --git a/x/slashing/keeper/infractions.go b/x/slashing/keeper/infractions.go
@@ -32,15 +32,23 @@ func (k Keeper) HandleValidatorSignatureWithParams(ctx context.Context, params t
 	consAddr := sdk.ConsAddress(addr)
 
 	// don't update missed blocks when validator's jailed
-	isJailed, err := k.sk.IsValidatorJailed(ctx, consAddr)
+	val, err := k.sk.ValidatorByConsAddr(ctx, consAddr)
 	if err != nil {
 		return err
 	}
 
-	if isJailed {
+	if val.IsJailed() {
 		return nil
 	}
 
+	// read the cons address again because validator may've rotated it's key
+	valConsAddr, err := val.GetConsAddr()
+	if err != nil {
+		return err
+	}
+
+	consAddr = sdk.ConsAddress(valConsAddr)
+
 	// fetch signing info
 	signInfo, err := k.ValidatorSigningInfo.Get(ctx, consAddr)
 	if err != nil {

diff --git a/x/slashing/keeper/signing_info.go b/x/slashing/keeper/signing_info.go
@@ -252,6 +252,12 @@ func (k Keeper) performConsensusPubKeyUpdate(ctx context.Context, oldPubKey, new
 		return types.ErrInvalidConsPubKey.Wrap("failed to get signing info for old public key")
 	}
 
+	consAddr, err := k.sk.ConsensusAddressCodec().BytesToString(newPubKey.Address())
+	if err != nil {
+		return err
+	}
+
+	signingInfo.Address = consAddr
 	if err := k.ValidatorSigningInfo.Set(ctx, sdk.ConsAddress(newPubKey.Address()), signingInfo); err != nil {
 		return err
 	}

diff --git a/x/slashing/keeper/signing_info_test.go b/x/slashing/keeper/signing_info_test.go
@@ -124,7 +124,7 @@ func (s *KeeperTestSuite) TestPerformConsensusPubKeyUpdate() {
 	newConsAddr := sdk.ConsAddress(pks[1].Address())
 
 	newInfo := slashingtypes.NewValidatorSigningInfo(
-		oldConsAddr.String(),
+		newConsAddr.String(),
 		int64(4),
 		int64(3),
 		time.Unix(2, 0).UTC(),