feat: consensus key rotation of validator #15165
Conversation
github-actions
bot
added
C:CLI
C:Simulations
C:x/distribution
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
|
|
||
| feePool.CommunityPool = feePool.CommunityPool.Add(sdk.NewDecCoinsFromCoins(rotationFee)...) | ||
| h.k.FeePool.Set(ctx, feePool) |
Check warning
Code scanning / gosec
Errors unhandled.
| prefixIterator := storetypes.KVStorePrefixIterator(store, key) | ||
| defer prefixIterator.Close() | ||
|
|
||
| for ; prefixIterator.Valid(); prefixIterator.Next() { |
Check warning
Code scanning / CodeQL
Unreachable statement
| return err | ||
| } | ||
|
|
||
| h.k.deleteAddrPubkeyRelation(ctx, oldPubKey.Address()) |
Check warning
Code scanning / gosec
Errors unhandled.
| newConsKey := k.sk.GetMappedConsKey(sdkCtx, consAddr) | ||
| si, err := k.GetValidatorSigningInfo(ctx, newConsKey) | ||
| if err != nil { | ||
| panic(fmt.Sprintf("Expected signing info for validator %s but not found %v", consAddr, err)) |
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
converting to draft for now, we will come to it once our plate clears up thank you |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
ref: #18141 |
Description
ref: #5231
Upstream from: iqlusioninc#2
included changes from: #9016
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change