chore(x/genutil): cleanup CollectTxs #17816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-prbot
requested review from
a team,
tac0turtle and
likhita-809
and removed request for
a team
julienrbrt
changed the title
julienrbrt
requested changes
Sep 20, 2023
julienrbrt
reviewed
Sep 20, 2023
This change reuses the already created sdk.AccAddress.String() []byte->string (sure it is cached but unnecessary to re-invoke) as a key to the balancesMap. Fixes #17814
odeke-em
force-pushed
the
x-genutils-cleanup
branch
from
4da52f3 to
54d1e64
Compare
|
Got and thanks for the review @julienrbrt, please see the latest! |
julienrbrt
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change moves []os.DirEntry close to where it is used and also reuses the already created sdk.AccAddress.String() []byte->string (sure it is cached but unnecessary to re-invoke) as a key to the balancesMap.
Fixes #17814
/cc @elias-orijtech