refactor(store): add missing error checks in store #17817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -223,7 +223,9 @@ | |||
| // Implements types.KVStore. | |||
| func (st *Store) Delete(key []byte) { | |||
| defer telemetry.MeasureSince(time.Now(), "store", "iavl", "delete") | |||
| st.tree.Remove(key) | |||
| if _, _, err := st.tree.Remove(key); err != nil { | |||
| panic(err) | |||
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods Warning
| @@ -144,6 +144,8 @@ | |||
| // onWrite writes a KVStore operation to all of the WriteListeners | |||
| func (s *Store) onWrite(delete bool, key, value []byte) { | |||
| for _, l := range s.listeners { | |||
| l.OnWrite(s.parentStoreKey, key, value, delete) | |||
| if err := l.OnWrite(s.parentStoreKey, key, value, delete); err != nil { | |||
| panic(err) | |||
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods Warning
tac0turtle
reviewed
Sep 20, 2023
| @@ -1068,7 +1068,9 @@ func (rs *Store) GetCommitInfo(ver int64) (*types.CommitInfo, error) { | |||
| func (rs *Store) flushMetadata(db dbm.DB, version int64, cInfo *types.CommitInfo) { | |||
| rs.logger.Debug("flushing metadata", "height", version) | |||
| batch := db.NewBatch() | |||
| defer batch.Close() | |||
| defer func() { | |||
| _ = batch.Close() | |||
There was a problem hiding this comment.
why have this instead of only batch.Close()?
There was a problem hiding this comment.
because otherwise the error isn't checked. (here too, but now it's explicitly not checked)
tac0turtle
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A-7
Relates to #17794, but targets v0.47.
Store is its own go.mod on main.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdmake lintandmake testReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change