Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add proto for cons pubkey rotation #18140

Merged
merged 13 commits into from
Oct 17, 2023
Merged

feat: add proto for cons pubkey rotation #18140

merged 13 commits into from
Oct 17, 2023

Conversation

atheeshp
Copy link
Contributor

@atheeshp atheeshp commented Oct 17, 2023 •
edited
Loading

Description

ref: #18141

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@atheeshp atheeshp requested a review from tac0turtle October 17, 2023 06:17
@atheeshp atheeshp mentioned this pull request Oct 17, 2023
Closed
7 tasks
@atheeshp atheeshp changed the title feat: add proto for cons rotate key feat: add proto for cons pubkey rotation Oct 17, 2023
@atheeshp atheeshp marked this pull request as ready for review October 17, 2023 12:16
@atheeshp atheeshp requested a review from a team as a code owner October 17, 2023 12:16
@github-prbot github-prbot requested review from a team and samricotta and removed request for a team October 17, 2023 12:16
@github-actions
Copy link
Contributor

@atheeshp your pull request is missing a changelog!

@atheeshp atheeshp added this pull request to the merge queue Oct 17, 2023
Merged via the queue into main with commit 8f8e242 Oct 17, 2023
53 checks passed
@atheeshp atheeshp deleted the ap/consensus-key-rotation-proto branch October 17, 2023 12:44
julienrbrt
julienrbrt reviewed Oct 17, 2023
View reviewed changes
proto/cosmos/staking/v1beta1/tx.proto

// RotateConsPubKey defines an operation for rotating the consensus keys
// of a validator.
// Since: cosmos-sdk 0.48
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since 0.51

@atheeshp atheeshp mentioned this pull request Oct 18, 2023
Merged
20 tasks
@coderabbitai coderabbitai bot mentioned this pull request Oct 31, 2023
Merged
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienrbrt julienrbrt julienrbrt left review comments

@tac0turtle tac0turtle tac0turtle approved these changes

@samricotta samricotta Awaiting requested review from samricotta

Assignees
No one assigned
Labels
C:x/feegrant C:x/staking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@atheeshp @tac0turtle @julienrbrt