Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(x/genutil): audit genutil #21471

Merged
merged 1 commit into from
Aug 30, 2024
Merged

docs(x/genutil): audit genutil #21471

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions x/genutil/client/cli/commands.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,6 @@ import (
genutiltypes "github.com/cosmos/cosmos-sdk/x/genutil/types"
)

// TODO(serverv2): remove app exporter notion that is server v1 specific

type genesisMM interface {
DefaultGenesis() map[string]json.RawMessage
ValidateGenesis(genesisData map[string]json.RawMessage) error
Expand Down
2 changes: 1 addition & 1 deletion x/genutil/v2/cli/commands.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ type genesisMM interface {

// Commands adds core sdk's sub-commands into genesis command.
func Commands(genutilModule genutil.AppModule, genMM genesisMM, appExport v2.AppExporter) *cobra.Command {
return CommandsWithCustomMigrationMap(genutilModule, genMM, appExport, genutiltypes.MigrationMap{})
return CommandsWithCustomMigrationMap(genutilModule, genMM, appExport, cli.MigrationMap)
}

// CommandsWithCustomMigrationMap adds core sdk's sub-commands into genesis command with custom migration map.
Expand Down
5 changes: 5 additions & 0 deletions x/genutil/v2/doc.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
// v2 contains logic and CLI used for genutil by server/v2 / runtime/v2 applications.
// It contains the AppExporter struct which is used when exporting the application state.
// Additionnaly it holds the a custom Export command specific to the v2 application.
// The rest of the CLI commands are the same as the ones in the genutil module.
package v2
Loading