chore: remove accounts replaces #21504
Conversation
WalkthroughWalkthroughThe changes involve the removal of local replace directives for the Changes
Possibly related issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
Early access features: disabledWe are currently testing the following features in early access:
Note:
|
github-actions
bot
added
C:x/staking
C:CLI
C:x/gov
C:x/slashing
C:x/distribution
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
Files ignored due to path filters (1)
x/group/go.sumis excluded by!**/*.sum
Files selected for processing (21)
- client/v2/go.mod (1 hunks)
- go.mod (1 hunks)
- server/v2/cometbft/go.mod (1 hunks)
- x/auth/go.mod (1 hunks)
- x/authz/go.mod (1 hunks)
- x/bank/go.mod (1 hunks)
- x/circuit/go.mod (1 hunks)
- x/consensus/go.mod (1 hunks)
- x/distribution/go.mod (1 hunks)
- x/epochs/go.mod (1 hunks)
- x/evidence/go.mod (1 hunks)
- x/feegrant/go.mod (1 hunks)
- x/gov/go.mod (1 hunks)
- x/group/go.mod (2 hunks)
- x/mint/go.mod (1 hunks)
- x/nft/go.mod (1 hunks)
- x/params/go.mod (1 hunks)
- x/protocolpool/go.mod (1 hunks)
- x/slashing/go.mod (1 hunks)
- x/staking/go.mod (1 hunks)
- x/upgrade/go.mod (1 hunks)
Files skipped from review due to trivial changes (17)
- go.mod
- server/v2/cometbft/go.mod
- x/authz/go.mod
- x/circuit/go.mod
- x/consensus/go.mod
- x/distribution/go.mod
- x/epochs/go.mod
- x/evidence/go.mod
- x/feegrant/go.mod
- x/gov/go.mod
- x/mint/go.mod
- x/nft/go.mod
- x/params/go.mod
- x/protocolpool/go.mod
- x/slashing/go.mod
- x/staking/go.mod
- x/upgrade/go.mod
Additional comments not posted (7)
x/auth/go.mod (1)
Line range hint
1-137: Approve the removal of the replace directive for theaccountsmodule.The change removes the local replacement for the
cosmossdk.io/x/accountsmodule:-replace cosmossdk.io/x/accounts => ../accountsThis indicates a shift towards using the official version of the
accountsmodule instead of a local copy. The removal may affect how dependencies are resolved and could have implications for the functionality and integration of thex/authmodule with other components.To verify the impact of this change, run the following script:
Verification successful
Verification Successful: No Issues Found with
accountsModule ImportsThe removal of the replace directive for the
cosmossdk.io/x/accountsmodule in thego.modfile is consistent with the rest of the codebase. All imports of theaccountsmodule are from the official source, confirming that the transition is complete and correct. No issues were found.
- All imports are from
cosmossdk.io/x/accounts.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the usage of the `accounts` module in the `x/auth` module. # Test: Search for import statements of the `accounts` module. Expect: Only imports from the official `cosmossdk.io/x/accounts` module. rg --type go -A 5 $'cosmossdk.io/x/accounts'Length of output: 41785
client/v2/go.mod (1)
Line range hint
1-1: Removed replace directive for the accounts module.The removal of the replace directive for the
cosmossdk.io/x/accountsmodule is in line with the PR objective of eliminating the use of the accounts module replacements across the Cosmos SDK.x/group/go.mod (5)
Line range hint
1-1: Verify the impact of removing thecosmossdk.io/core/testingpackage on existing tests.Ensure that removing this testing package doesn't break any existing tests for the
x/groupmodule.Run the following script to verify the impact:
Line range hint
1-1: Verify the impact of removing thecosmossdk.io/x/distributionpackage on existing functionality and tests.Ensure that removing this distribution package doesn't break any existing functionality or tests for the
x/groupmodule.Run the following script to verify the impact:
Line range hint
1-1: Verify the impact of removing thecosmossdk.io/x/accounts/defaults/lockuppackage on existing functionality and tests.Ensure that removing this lockup package doesn't break any existing functionality or tests for the
x/groupmodule.Run the following script to verify the impact:
Verification successful
Verification Successful: No Impact from Removal of
lockupPackageThe
x/groupmodule does not contain any references to thecosmossdk.io/x/accounts/defaults/lockuppackage, indicating that its removal from therequiresection does not impact the module's functionality.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify that removing the `cosmossdk.io/x/accounts/defaults/lockup` package doesn't break existing functionality and tests. # Test: Search for import statements of the removed package. Expect: No occurrences. rg --type go $'cosmossdk.io/x/accounts/defaults/lockup' # Test: Run the tests for the `x/group` module. Expect: All tests pass. go test ./x/group/...Length of output: 2390
Script:
#!/bin/bash # Description: Verify that there are no references to the `cosmossdk.io/x/accounts/defaults/lockup` package in the `x/group` module. # Search for any references to the `lockup` package within the `x/group` module. rg --type go 'lockup' ./x/groupLength of output: 31
Line range hint
1-1: Verify the impact of removing thecosmossdk.io/x/accounts/defaults/multisigpackage on existing functionality and tests.Ensure that removing this multisig package doesn't break any existing functionality or tests for the
x/groupmodule.Run the following script to verify the impact:
Verification successful
No Impact on
x/groupModule from RemovingmultisigPackageThe removal of the
cosmossdk.io/x/accounts/defaults/multisigpackage from therequiresection in thex/groupmodule'sgo.modfile does not affect the module's functionality or tests, as there are no references to this package within the module.
- No references to
cosmossdk.io/x/accounts/defaults/multisigwere found in thex/groupmodule.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify that removing the `cosmossdk.io/x/accounts/defaults/multisig` package doesn't break existing functionality and tests. # Test: Search for import statements of the removed package. Expect: No occurrences. rg --type go $'cosmossdk.io/x/accounts/defaults/multisig' # Test: Run the tests for the `x/group` module. Expect: All tests pass. go test ./x/group/...Length of output: 794
Script:
#!/bin/bash # Description: Search for references to the removed package within the `x/group` module's test files. # Find all test files in the `x/group` module and search for the removed package. fd --type f --extension go --exec rg 'cosmossdk.io/x/accounts/defaults/multisig' {}Length of output: 446
Script:
#!/bin/bash # Description: Search for references to the removed package within the `x/group` module's test files and include file paths in the output. # Find all test files in the `x/group` module and search for the removed package, including file paths in the output. fd --type f --extension go --exec rg --with-filename 'cosmossdk.io/x/accounts/defaults/multisig' {}Length of output: 759
Line range hint
1-1: Verify the impact of removing thereplacedirective forcosmossdk.io/x/accountson version compatibility and existing functionality and tests.Ensure that removing this
replacedirective doesn't introduce any version incompatibilities or break any existing functionality or tests for thex/groupmodule.Run the following script to verify the impact:
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
Files ignored due to path filters (1)
x/group/go.sumis excluded by!**/*.sum
Files selected for processing (21)
- client/v2/go.mod (1 hunks)
- go.mod (1 hunks)
- server/v2/cometbft/go.mod (1 hunks)
- x/auth/go.mod (1 hunks)
- x/authz/go.mod (1 hunks)
- x/bank/go.mod (1 hunks)
- x/circuit/go.mod (1 hunks)
- x/consensus/go.mod (1 hunks)
- x/distribution/go.mod (1 hunks)
- x/epochs/go.mod (1 hunks)
- x/evidence/go.mod (1 hunks)
- x/feegrant/go.mod (1 hunks)
- x/gov/go.mod (1 hunks)
- x/group/go.mod (2 hunks)
- x/mint/go.mod (1 hunks)
- x/nft/go.mod (1 hunks)
- x/params/go.mod (1 hunks)
- x/protocolpool/go.mod (1 hunks)
- x/slashing/go.mod (1 hunks)
- x/staking/go.mod (1 hunks)
- x/upgrade/go.mod (1 hunks)
Files skipped from review due to trivial changes (21)
- client/v2/go.mod
- go.mod
- server/v2/cometbft/go.mod
- x/auth/go.mod
- x/authz/go.mod
- x/bank/go.mod
- x/circuit/go.mod
- x/consensus/go.mod
- x/distribution/go.mod
- x/epochs/go.mod
- x/evidence/go.mod
- x/feegrant/go.mod
- x/gov/go.mod
- x/group/go.mod
- x/mint/go.mod
- x/nft/go.mod
- x/params/go.mod
- x/protocolpool/go.mod
- x/slashing/go.mod
- x/staking/go.mod
- x/upgrade/go.mod
|
looks like group needs it. Let's backport too. |
julienrbrt
added
the
backport/v0.52.x
|
go mod tidy all needed it seems: https://github.com/cosmos/cosmos-sdk/actions/runs/10670155990/job/29573581973?pr=21504 |
(cherry picked from commit 9197f54) # Conflicts: # client/v2/go.mod # go.mod # server/v2/cometbft/go.mod # x/auth/go.mod # x/authz/go.mod # x/bank/go.mod # x/circuit/go.mod # x/consensus/go.mod # x/distribution/go.mod # x/epochs/go.mod # x/evidence/go.mod # x/feegrant/go.mod # x/gov/go.mod # x/mint/go.mod # x/nft/go.mod # x/params/go.mod # x/protocolpool/go.mod # x/slashing/go.mod # x/staking/go.mod # x/upgrade/go.mod
Co-authored-by: Marko <[email protected]> Co-authored-by: Julien Robert <[email protected]>
Description
this pr removes accounts module replaces in all modules
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.
I have...
Summary by CodeRabbit
cosmossdk.io/x/accountsmodule across multiple modules, indicating a shift towards using the upstream version for dependency resolution.