Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sims): Use liveness matrix for val sign status in sims #21952

Merged
merged 2 commits into from
Sep 27, 2024
Merged

fix(sims): Use liveness matrix for val sign status in sims #21952

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b0eb32e
Use liveness matrix for val sign status in sims
alpe Sep 27, 2024
0ef5352
Update changelog
alpe Sep 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,8 @@ Every module contains its own CHANGELOG.md. Please refer to the module you are i
* (sims) [#21613](https://github.com/cosmos/cosmos-sdk/pull/21613) Add sims2 framework and factory methods for simpler message factories in modules

### Bug Fixes

* (sims) [21906](https://github.com/cosmos/cosmos-sdk/pull/21906) Skip sims test when running dry on validators
* (sims) [#21952](https://github.com/cosmos/cosmos-sdk/pull/21952) Use liveness matrix for validator sign status in sims
* (sims) [#21906](https://github.com/cosmos/cosmos-sdk/pull/21906) Skip sims test when running dry on validators
* (cli) [#21919](https://github.com/cosmos/cosmos-sdk/pull/21919) Query address-by-acc-num by account_id instead of id.

### API Breaking Changes
Expand Down
5 changes: 4 additions & 1 deletion x/simulation/mock_cometbft.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,18 +151,21 @@ func RandomRequestFinalizeBlock(
signed = false
}

var commitStatus cmtproto.BlockIDFlag
if signed {
event("begin_block", "signing", "signed")
commitStatus = cmtproto.BlockIDFlagCommit
} else {
event("begin_block", "signing", "missed")
commitStatus = cmtproto.BlockIDFlagAbsent
}

voteInfos[i] = abci.VoteInfo{
Validator: abci.Validator{
Address: SumTruncated(mVal.val.PubKeyBytes),
Power: mVal.val.Power,
},
BlockIdFlag: cmtproto.BlockIDFlagCommit,
BlockIdFlag: commitStatus,
}
}

Expand Down
Loading