Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix typos in various documentation files #22722

Merged
merged 9 commits into from
Dec 3, 2024

Conversation

Dimitrolito
Copy link
Contributor

@Dimitrolito Dimitrolito commented Dec 2, 2024

This PR addresses several typographical errors across different documentation files. The changes include:

  • Corrected the spelling of "cross check" to "cross-check" in the CODING_GUIDELINES.md file.
  • Updated the phrase "up to date" to "up-to-date" in the RELEASE_PROCESS.md file.
  • Fixed the use of "one year" to "one-year" in ROADMAP.md.
  • Corrected "an unique" to "a unique" in adr-049-state-sync-hooks.md.
  • Fixed hyphenation in "per member" to "per-member" in adr-008-dCERT-group.md.
  • Addressed "fine grained" to "fine-grained" in adr-033-protobuf-inter-module-comm.md.

Author Checklist:

  • Included the correct type prefix in the PR title.
  • Targeted the correct branch.
  • Provided a link to the relevant issue or specification.
  • Reviewed "Files changed" and left comments if necessary.
  • Included necessary tests (if applicable).
  • Updated the documentation accordingly.

Reviewers Checklist:

  • Confirmed the correct type prefix in the PR title.
  • Reviewed the changes in documentation for accuracy.
  • Confirmed all author checklist items have been addressed.

Summary by CodeRabbit

  • Documentation
    • Enhanced clarity and structure in CODING_GUIDELINES.md, emphasizing coding standards and testing practices.
    • Clarified release procedures in RELEASE_PROCESS.md, improving grammatical accuracy and readability.
    • Minor textual modifications in ROADMAP.md for grammatical consistency.
    • Updated adr-008-dCERT-group.md with detailed operational framework for the Decentralized Computer Emergency Response Team (dCERT).
    • Revised adr-033-protobuf-inter-module-comm.md to improve inter-module communication using Protocol Buffers.
    • Introduced hooks-based state synchronization in adr-049-state-sync-hooks.md, enhancing state management capabilities.

@Dimitrolito Dimitrolito requested a review from a team as a code owner December 2, 2024 18:54
Copy link
Contributor

coderabbitai bot commented Dec 2, 2024

📝 Walkthrough
📝 Walkthrough

Walkthrough

The pull request includes modifications to several documentation files within the Cosmos SDK repository, focusing on enhancing clarity, structure, and grammatical accuracy. Key documents updated include CODING_GUIDELINES.md, RELEASE_PROCESS.md, ROADMAP.md, and various architecture decision records (ADRs). Changes involve refining headings, improving formatting, and expanding sections to provide clearer guidance on coding practices, release procedures, and governance structures. New types and interfaces have been introduced in specific ADRs to support enhanced functionality and security in module interactions and state synchronization.

Changes

File Path Change Summary
CODING_GUIDELINES.md Refined section headers and bullet points for readability; expanded Acceptance Tests section; emphasized automated testing and QA team roles.
RELEASE_PROCESS.md Clarified release procedures; added hyphens for grammatical accuracy; retained major and patch release instructions with improved clarity.
ROADMAP.md Minor textual modifications; corrected phrasing for objectives; improved grammatical accuracy.
docs/architecture/adr-008-dCERT-group.md Enhanced clarity and detail regarding the dCERT group's governance and operational framework; introduced new parameters for dCERT operations.
docs/architecture/adr-033-protobuf-inter-module-comm.md Introduced Protocol Buffers for inter-module communication; added new types and interfaces for secure message passing; outlined security considerations.
docs/architecture/adr-049-state-sync-hooks.md Introduced hooks-based state synchronization; added new message types and interfaces for managing external state data; clarified snapshot ordering and compatibility.

Possibly related PRs

Suggested reviewers

  • sontrinh16
  • tac0turtle

📜 Recent review details

Configuration used: .coderabbit.yml
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 960a8a5 and 8f3e1d0.

📒 Files selected for processing (1)
  • RELEASE_PROCESS.md (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • RELEASE_PROCESS.md

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

📜 Review details

Configuration used: .coderabbit.yml
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 9d9c19c and 960a8a5.

📒 Files selected for processing (6)
  • CODING_GUIDELINES.md (1 hunks)
  • RELEASE_PROCESS.md (2 hunks)
  • ROADMAP.md (2 hunks)
  • docs/architecture/adr-008-dCERT-group.md (1 hunks)
  • docs/architecture/adr-033-protobuf-inter-module-comm.md (1 hunks)
  • docs/architecture/adr-049-state-sync-hooks.md (1 hunks)
🧰 Additional context used
📓 Path-based instructions (6)
CODING_GUIDELINES.md (1)

Pattern **/*.md: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"

RELEASE_PROCESS.md (1)

Pattern **/*.md: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"

docs/architecture/adr-008-dCERT-group.md (1)

Pattern **/*.md: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"

docs/architecture/adr-049-state-sync-hooks.md (1)

Pattern **/*.md: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"

docs/architecture/adr-033-protobuf-inter-module-comm.md (1)

Pattern **/*.md: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"

ROADMAP.md (1)

Pattern **/*.md: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"

🪛 LanguageTool
RELEASE_PROCESS.md

[grammar] ~60-~60: The plural noun “PRs” cannot be used with the article “a”. Did you mean “a PR” or “PRs”?
Context: ...ne by automatic cherry-pick followed by a PRs to the release branch). The backports m...

(A_NNS)

ROADMAP.md

[uncategorized] ~270-~270: Possible missing comma found.
Context: ...hat was not. Shortly before the quarter concludes a new section will be added for the nex...

(AI_HYDRA_LEO_MISSING_COMMA)

🔇 Additional comments (6)
CODING_GUIDELINES.md (1)

151-151: LGTM: Correct hyphenation of compound modifier

The change from "cross check" to "cross-check" follows proper English hyphenation rules for compound modifiers.

docs/architecture/adr-049-state-sync-hooks.md (1)

119-119: LGTM: Correct article usage

The change from "an unique" to "a unique" is grammatically correct. The article "a" is used before words beginning with a consonant sound, including "unique" which starts with a "yu" sound.

docs/architecture/adr-008-dCERT-group.md (1)

104-104: LGTM: Correct hyphenation of compound modifier

The change from "per member" to "per-member" follows proper English hyphenation rules for compound modifiers when they precede a noun.

RELEASE_PROCESS.md (1)

30-30: LGTM: Correct hyphenation of compound adjective

The change from "up to date" to "up-to-date" is grammatically correct as it's used as a compound adjective before the noun "UPGRADING.md file".

docs/architecture/adr-033-protobuf-inter-module-comm.md (1)

157-157: LGTM: Correct hyphenation of compound adjective

The change from "fine grained" to "fine-grained" is grammatically correct as it's used as a compound adjective.

ROADMAP.md (1)

148-148: LGTM: Correct article usage before acronym

The change from "a RFC/ADR" to "an RFC/ADR" is correct as "RFC" is pronounced as "ar-ef-see", starting with a vowel sound.

RELEASE_PROCESS.md Outdated Show resolved Hide resolved
ROADMAP.md Show resolved Hide resolved
@julienrbrt julienrbrt changed the title Fix typos in various documentation files docs: fix typos in various documentation files Dec 2, 2024
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@julienrbrt julienrbrt enabled auto-merge December 3, 2024 09:03
@julienrbrt julienrbrt added this pull request to the merge queue Dec 3, 2024
Merged via the queue into cosmos:main with commit 78c8057 Dec 3, 2024
71 of 72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants