Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add v0.47.15 and v0.50.11 changelog to main #22911

Merged
merged 2 commits into from
Dec 17, 2024

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Dec 16, 2024

Description

Release chores.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title, you can find examples of the prefixes below:
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Summary by CodeRabbit

  • New Features

    • Introduced a Linux-only backend for the crypto/keyring module, supporting the Linux kernel's keyctl.
  • Improvements

    • Regenerated addrbook.json for in-place testnets.
    • Updated RocksDB version.
  • Bug Fixes

    • Fixed fallback genesis path in the server.
    • Improved address rendering in errors for the x/group module.
    • Updated query for address-by-acc-num to use account_id instead of id.
    • Adjusted sims test to skip when running low on validators.
  • Documentation

    • Updated CHANGELOG.md with new version entries and modifications.

@julienrbrt julienrbrt requested a review from a team as a code owner December 16, 2024 20:32
Copy link
Contributor

coderabbitai bot commented Dec 16, 2024

📝 Walkthrough

Walkthrough

This pull request involves updates to the CHANGELOG.md for the Cosmos SDK, specifically for version v0.50.11. The changes include introducing a new Linux-only backend for the crypto/keyring module, improvements to the server and RocksDB, and several bug fixes. The errors package changelog has also been updated to version 2.0.0, removing gRPC error codes and certain functions in favor of standard Go library errors.

Changes

File Change Summary
CHANGELOG.md Added v0.50.11 version entry with new features, improvements, and bug fixes
errors/CHANGELOG.md Updated to v2.0.0 with API breaking changes, removed gRPC error codes
errors/go.mod Added comment about zero dependencies, no other changes

Possibly related PRs

Suggested Labels

backport/v0.50.x, C:Store, C:x/group, C:core/testing

Suggested Reviewers

  • sontrinh16
  • akhilkumarpilli
  • hieuvubk

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (4)
errors/CHANGELOG.md (2)

38-38: Improve conciseness of the explanation

The explanation could be more concise while maintaining clarity.

-Remove Grpc error codes from the error package. This is done in order to keep the dependency graph of errors minimal
+Remove Grpc error codes from the error package to minimize the dependency graph
🧰 Tools
🪛 LanguageTool

[style] ~38-~38: Consider a shorter alternative to avoid wordiness.
Context: ...es from the error package. This is done in order to keep the dependency graph of errors min...

(IN_ORDER_TO_PREMIUM)


39-39: Consider enhancing migration guidance

While the migration path is mentioned, it would be helpful to structure it more clearly for developers.

-Removes `IsOf`, `Recover`, `WithType` and wrapped error. The errors package uses the go std library errors. It provides a `Wrap` and `Wrapf` to help in the migration from v1 to v2.
+Removes the following functions in favor of Go's standard library errors:
+* `IsOf`
+* `Recover`
+* `WithType`
+* wrapped error
+
+Migration path:
+* Use the provided `Wrap` and `Wrapf` functions for error wrapping
+* Use `errors.Is` and `errors.As` from the standard library for error checking
CHANGELOG.md (2)

809-812: Security advisory should include CVE identifier if available

The security fix for ABS-0043/ABS-0044 should ideally include the CVE identifier if one was assigned, to help users track and reference the vulnerability.


57-57: Consider adding release date to unreleased section

The unreleased section should include an estimated target release date to help users plan for upcoming changes.

📜 Review details

Configuration used: .coderabbit.yml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ee5da1a and 9fc3788.

📒 Files selected for processing (3)
  • CHANGELOG.md (3 hunks)
  • errors/CHANGELOG.md (1 hunks)
  • errors/go.mod (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • errors/go.mod
🧰 Additional context used
📓 Path-based instructions (2)
errors/CHANGELOG.md (1)

Pattern **/*.md: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"

CHANGELOG.md (1)

Pattern **/*.md: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"

🪛 LanguageTool
errors/CHANGELOG.md

[style] ~38-~38: Consider a shorter alternative to avoid wordiness.
Context: ...es from the error package. This is done in order to keep the dependency graph of errors min...

(IN_ORDER_TO_PREMIUM)

🔇 Additional comments (2)
errors/CHANGELOG.md (1)

34-36: LGTM! Version header is well-formatted

The version header follows the Keep a Changelog format and includes a proper link to the release.

CHANGELOG.md (1)

Line range hint 1-813: LGTM! The changelog follows best practices for documentation

The changelog is well-structured with:

  • Consistent formatting and categorization
  • Clear PR references
  • Detailed descriptions of changes
  • Proper semantic versioning
  • Security fixes clearly highlighted

@julienrbrt julienrbrt enabled auto-merge December 16, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants