-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: updates Example, Use auctocli #23088
Conversation
📝 WalkthroughWalkthroughThe pull request introduces two minor modifications to the autocli configuration in the distribution and staking modules. In the distribution module, the example command for delegation rewards is updated to use a more specific command name "rewards-by-validator". In the staking module, a new "Use" field is added to the validators RPC command options, providing a clearer command-line interface for querying validators. Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Tip CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
x/distribution/autocli.go (1)
66-66
: Consider rephrasing for clarity in usage instructions.
Currently, the short description reads: “Query all distribution delegator from a particular validator,” which can be ambiguous. A clearer phrasing might be “Query distribution rewards from a particular validator for a given delegator.”
📜 Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
x/distribution/autocli.go
(1 hunks)x/staking/autocli.go
(1 hunks)
🧰 Additional context used
📓 Path-based instructions (2)
x/staking/autocli.go (1)
Pattern **/*.go
: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.
x/distribution/autocli.go (1)
Pattern **/*.go
: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.
🔇 Additional comments (1)
x/staking/autocli.go (1)
20-20
: LGTM.
Adding "validators"
to the Use
field improves clarity and consistency, matching established CLI naming patterns.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
@Mergifyio backport release/v0.52.x |
✅ Backports have been created
|
(cherry picked from commit e39065d)
Co-authored-by: DongLieu <[email protected]>
Description
Closes: #XXXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
in the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.
I have...
Summary by CodeRabbit
New Features
Bug Fixes