test(systemtest): Fix QueryBySig
#23102
Conversation
hieuvubk
requested review from
facundomedica,
sontrinh16 and
a team
as code owners
📝 WalkthroughWalkthroughThe pull request introduces a new variable Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Tip CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
github-actions
bot
added
C:server/v2
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
server/v2/cometbft/grpc.go (1)
529-535: Consider verifying and customizing sign modes if needed.
By default,authtx.NewTxConfigusesDefaultSignModes. If the chain requires additional or restricted sign modes, consider specifying them directly instead of the defaults.
📜 Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
server/v2/cometbft/grpc.go(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
server/v2/cometbft/grpc.go (1)
Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.
🔇 Additional comments (1)
server/v2/cometbft/grpc.go (1)
541-542: Great use of method chaining for context setup.
Chaining .WithClient(rpcClient) and .WithTxConfig(txConfig) is clear and aligns with idiomatic Go in the Cosmos SDK.
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
server/v2/cometbft/grpc.go (1)
529-535: Validate the usage ofauthtx.NewTxConfigand consider sign modes manageability.The current usage of
authtx.NewTxConfigis valid for establishingTxConfigwith default sign modes. However, if your application requires more flexible or specialized sign modes, consider making sign modes configurable instead of relying on defaults alone.
📜 Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
server/v2/cometbft/grpc.go(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
server/v2/cometbft/grpc.go (1)
Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.
| WithClient(rpcClient). | ||
| WithTxConfig(txConfig) |
There was a problem hiding this comment.
Handle potential errors from RPC client creation.
You’re calling rpchttp.New(...) above without checking its error. This could lead to runtime issues if the RPC client fails to initialize. It’s recommended to validate and handle this error path rather than ignoring it.
- rpcClient, _ := rpchttp.New(c.cfg.AppTomlConfig.RPC.ListenAddress)
+ rpcClient, err := rpchttp.New(c.cfg.AppTomlConfig.RPC.ListenAddress)
+ if err != nil {
+ return nil, fmt.Errorf("failed to create RPC client: %w", err)
+ }Committable suggestion skipped: line range outside the PR's diff.
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
tests/systemtests/tx_test.go (1)
950-950: Enhance error message phrasing for consistencyIn Go, error messages typically follow the convention of starting with a lowercase verb and avoiding phrases like "failed" at the end. Consider using something like
"failed to unmarshal legacytx.StdTx"or"could not unmarshal legacytx.StdTx"for improved readability.- {"invalid tx bytes", &tx.TxDecodeAminoRequest{AminoBinary: invalidTxBytes}, true, "unmarshal to legacytx.StdTx failed"}, + {"invalid tx bytes", &tx.TxDecodeAminoRequest{AminoBinary: invalidTxBytes}, true, "failed to unmarshal legacytx.StdTx"},
📜 Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
tests/systemtests/tx_test.go(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
tests/systemtests/tx_test.go (3)
Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.
Pattern tests/**/*: "Assess the integration and e2e test code assessing sufficient code coverage for the changes associated in the pull request"
Pattern **/*_test.go: "Assess the unit test code assessing sufficient code coverage for the changes associated in the pull request"
|
@Mergifyio backport release/v0.52.x |
✅ Backports have been created
|
(cherry picked from commit 784d1c8)
Description
Closes: #XXXX
TxConfigto comet clientCtx forauthtx.formatTxResultsAuthor Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.
I have...
Summary by CodeRabbit
New Features
Bug Fixes