fix(build): fix build tags

[kocubinski]

Description

Fixes propagation of COSMOS_BUILD_OPTIONS. For example, without this fix I cannot build with the tag "benchmark".

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title, you can find examples of the prefixes below:
• confirmed ! in the type prefix if API or client breaking change
• targeted the correct branch (see PR Targeting)
• provided a link to the relevant issue or specification
• reviewed "Files changed" and left comments if necessary
• included the necessary unit and integration tests
• added a changelog entry to CHANGELOG.md
• updated the relevant documentation or specification, including comments for documenting Go code
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.

I have...

• confirmed the correct type prefix in the PR title
• confirmed all author checklist items have been addressed
• reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Summary by CodeRabbit

• Chores
  • Updated build configuration to support more flexible build options.
  • Updated rocksdb_version to the latest version (v9.7.3).
• Tests
  • Improved test failure reporting by marking the Example function as a helper.
  • Simplified variable declaration for mintKeeper in the test suite.

[coderabbitai]

📝 Walkthrough

Walkthrough

The pull request modifies the COSMOS_BUILD_OPTIONS and rocksdb_version variables in the scripts/build/build.mk file. The COSMOS_BUILD_OPTIONS variable is changed from a simple assignment to an augmented assignment, allowing for the addition of further options. The rocksdb_version variable is updated from v9.6.1 to v9.7.3. The rest of the file remains unchanged, maintaining the existing build logic, error handling, and control flow.

Changes

File	Change Summary
scripts/build/build.mk	Updated COSMOS_BUILD_OPTIONS from := v2 to += ' v2' and changed rocksdb_version from v9.6.1 to v9.7.3
tests/integration/v2/example/example_test.go	Added t.Helper() to the Example function, simplified mintKeeper declaration, and added a comment to suppress a linting warning.

Possibly related PRs

• fix(crypto): bls compilation #22717: The changes in this PR involve modifications to the COSMOS_BUILD_OPTIONS variable in the build workflow, which directly relates to the changes made to the same variable in the main PR.
• fix(make): init-simapp #23037: Although this PR modifies a different makefile (scripts/build/testing.mk), it is still related to the build process within the same project context, indicating ongoing changes to build configurations.

Suggested labels

Type: CI, backport/v0.52.x

Suggested reviewers

• auricom
• julienrbrt

Tip

CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command @coderabbitai generate docstrings to have CodeRabbit automatically generate docstrings for your pull request. We would love to hear your feedback on Discord.

---

📜 Recent review details

Configuration used: .coderabbit.yml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2815e3b and a36f063.

📒 Files selected for processing (1)

• tests/integration/v2/example/example_test.go (1 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

tests/integration/v2/example/example_test.go (3)

Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.

---

Pattern tests/**/*: "Assess the integration and e2e test code assessing sufficient code coverage for the changes associated in the pull request"

---

Pattern **/*_test.go: "Assess the unit test code assessing sufficient code coverage for the changes associated in the pull request"

🔇 Additional comments (3)

tests/integration/v2/example/example_test.go (3)

25-25: Use comment-based directives judiciously.

The nolint:govet directive seems fine here, but make sure you add a concise explanation for future maintainers about why it's necessary—especially if the parameter signature is unconventional for a standard Go test function.

---

27-27: Good practice to mark the function as a test helper.

Calling t.Helper() at the start of the test function ensures that failures are reported from the correct call site, improving test readability and debugging.

---

30-30: Variable declaration granularity is appropriate.

The single-line declaration for mintKeeper is concise and clear. This change maintains readability and matchers typical Go style guidelines.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

scripts/build/build.mk (1)

15-15: Consider removing single quotes when appending "v2" to COSMOS_BUILD_OPTIONS
In Makefiles, literal single quotes can sometimes cause unpredictable string-matching behavior. Since you rely on ifeq (v2,$(findstring v2,$(COSMOS_BUILD_OPTIONS))) below, it’s safer to append v2 without quotes.

Below is a suggested fix:

- COSMOS_BUILD_OPTIONS += ' v2'
+ COSMOS_BUILD_OPTIONS += v2

📜 Review details

Configuration used: .coderabbit.yml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4fb2347 and f3efd30.

📒 Files selected for processing (1)

• scripts/build/build.mk (1 hunks)