Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend ClientConn on TxBuilder #7630

Closed
wants to merge 26 commits into from
Closed

Extend ClientConn on TxBuilder #7630

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
9c8486d
Add invoke & NewStream
amaury1093 Oct 22, 2020
2c36489
Remove validate basic
amaury1093 Oct 22, 2020
097c13f
Update test
amaury1093 Oct 22, 2020
b0e89dc
WIP
amaury1093 Oct 22, 2020
55c4a88
Merge branch 'master' of ssh://github.com/cosmos/cosmos-sdk into am-7…
amaury1093 Oct 23, 2020
7b44e68
NewAnyWithWithTypeURL
amaury1093 Oct 23, 2020
7b1e26a
Add todo comment for amino
amaury1093 Oct 23, 2020
2306164
Merge branch 'master' of ssh://github.com/cosmos/cosmos-sdk into am-7…
amaury1093 Oct 23, 2020
12cba1e
Add Changelog
amaury1093 Oct 23, 2020
73af333
Remove println
amaury1093 Oct 23, 2020
383b3e8
Update codec/types/any.go
amaury1093 Oct 23, 2020
24cdb72
Add AppendMsgs
amaury1093 Oct 23, 2020
70c0ebf
Rename SetMsgs to AppendMsgs
amaury1093 Oct 23, 2020
626319a
Merge branch 'am-7541-txbuilder' of ssh://github.com/cosmos/cosmos-sd…
amaury1093 Oct 23, 2020
3b75af0
Merge branch 'master' into am-7541-txbuilder
Oct 23, 2020
9a68044
Merge branch 'master' of ssh://github.com/cosmos/cosmos-sdk into am-7…
amaury1093 Oct 26, 2020
92679a4
Address review comments
amaury1093 Oct 26, 2020
4e2f3a5
Add comment
amaury1093 Oct 26, 2020
dc1613b
Typo
amaury1093 Oct 26, 2020
e5c6106
Merge branch 'master' into am-7541-txbuilder
amaury1093 Oct 26, 2020
b6209de
Merge branch 'master' of ssh://github.com/cosmos/cosmos-sdk into am-7…
amaury1093 Dec 11, 2020
173b75d
Use SetMsgs
amaury1093 Dec 11, 2020
7b9da51
remove AppendMsg
amaury1093 Dec 11, 2020
8083644
Add comments and CHANHGELOG
amaury1093 Dec 11, 2020
ade84b5
Add validate basic
amaury1093 Dec 11, 2020
7afe557
Merge branch 'master' of ssh://github.com/cosmos/cosmos-sdk into am-7…
amaury1093 Dec 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions x/auth/legacy/legacytx/msg_service.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,11 @@ func (s *StdTxBuilder) Invoke(_ gocontext.Context, method string, args, reply in
return sdkerrors.Wrapf(sdkerrors.ErrInvalidType, "%T should implement %T", args, (*sdk.MsgRequest)(nil))
}

err := req.ValidateBasic()
if err != nil {
return err
}

msgs := append(s.Msgs, sdk.ServiceMsg{
MethodName: method,
Request: req,
Expand Down
5 changes: 5 additions & 0 deletions x/auth/tx/msg_service.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,11 @@ func (w *wrapper) Invoke(_ gocontext.Context, method string, args, reply interfa
return sdkerrors.Wrapf(sdkerrors.ErrInvalidType, "%T should implement %T", args, (*sdk.MsgRequest)(nil))
}

err := req.ValidateBasic()
if err != nil {
return err
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't we use sdkerrors.Wrapf here?

Copy link
Contributor Author

@amaury1093 amaury1093 Dec 15, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thumbed up, but maybe it's not necessary. err should already be a SDK error. I used sdkerrors.Wrapf 3 lines above because there's no underlying error.

}

msgs := append(w.GetMsgs(), sdk.ServiceMsg{
MethodName: method,
Request: req,
Expand Down