Service msgs simulations #8188
Merged
Service msgs simulations #8188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## aleem/msg_auth #8188 +/- ##
==================================================
+ Coverage 61.77% 61.86% +0.08%
==================================================
Files 625 626 +1
Lines 35743 35926 +183
==================================================
+ Hits 22081 22225 +144
- Misses 11338 11361 +23
- Partials 2324 2340 +16
|
aaronc
reviewed
Dec 17, 2020
types/simulation/types.go
Outdated
| } | ||
| bz := cdc.MustMarshalJSON(srvMsg.Request) | ||
|
|
||
| return NewOperationMsgBasic(msg.Route(), msg.Type(), comment, ok, bz) |
There was a problem hiding this comment.
So we shouldn't worry about Route and Msg here I think. Instead we should use the MethodName.
anilcse
approved these changes
Dec 18, 2020
There was a problem hiding this comment.
lgtm, @aleem1314 let's merge this to your branch and address if any comments in the original PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes