Add client config subcommand to CLI

[cyberbono3]

Description

This PR implements the first step from Amaury's proposal.

• creates a new $NODE_DIR/config/client.toml file to hold all client-side configuration (chainID, keyringBackend, output, node, broadcastMode)
• provides set functionality (e.g. ./build/simd config node tcp://localhost:127)
• provides get functionality ((e.g. ./build/simd config node returns tcp://localhost:127)
• prints out current client configuration in JSON format (./build/simd config)
  Output: { "chain-id": "chain-7e7zGq","keyring-backend": "test", "output": "json","node": "tcp://localhost:26657","broadcast-mode": "async"}

Me and @clevinson made manual testing. I can make some automatic tests if needed in a separate PR.

closes: #8529

---

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

• Targeted PR against correct branch (see CONTRIBUTING.md)
• Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
• Code follows the module structure standards.
• Wrote unit and integration tests
• Updated relevant documentation (docs/) or specification (x/<module>/spec/)
• Added relevant godoc comments.
• Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
• Re-reviewed Files changed in the Github PR explorer
• Review Codecov Report in the comment section below once CI passes

[jackzampolin]

This is important work @cyberbono3

[alessio]

MustWriteFile is removed from future tendermint releases. I suggest adopting the following (and equivalent) form:

Suggested change

	tmos.MustWriteFile(configFilePath, buffer.Bytes(), 0644)
	return nil
	return ioutil.WriteFile(configFilePath, buffer.Bytes(), 0644)

[cyberbono3]

Done!

[amaury1093]

Functionally, it works well!

I tested:

1. `node` set in client.toml, no flag: uses node from client.toml
2. `node` set in client.toml, with `--node` flag: uses node from flag

Left some comments about the code.

[codecov]

Codecov Report

Merging #8953 (4a5a2b2) into master (feed37d) will decrease coverage by 0.02%.
The diff coverage is 34.48%.

@@            Coverage Diff             @@
##           master    #8953      +/-   ##
==========================================
- Coverage   58.96%   58.94%   -0.03%     
==========================================
  Files         575      575              
  Lines       32159    32171      +12     
==========================================
- Hits        18963    18962       -1     
- Misses      10982    10995      +13     
  Partials     2214     2214              

Impacted Files	Coverage Δ
client/cmd.go	56.77% <0.00%> (-0.49%)	⬇️
client/utils.go	41.93% <0.00%> (-1.40%)	⬇️
server/rosetta/converter.go	54.44% <ø> (ø)
x/auth/client/tx.go	36.06% <0.00%> (-3.23%)	⬇️
client/context.go	55.85% <40.00%> (-1.16%)	⬇️
simapp/simd/cmd/root.go	61.71% <71.42%> (+0.24%)	⬆️
client/keys/list.go	73.68% <100.00%> (-6.32%)	⬇️
testutil/network/network.go	90.00% <100.00%> (+0.04%)	⬆️
x/auth/client/cli/tx_sign.go	73.88% <100.00%> (-0.71%)	⬇️

[orijbot]

Benchmark beginning. Status page: https://github.orijtech.com/benchmark/status?commit=a889d7efe871565a16581f2e439aaac4121a0cc4

[orijbot]

Benchmark beginning. Status page: https://github.orijtech.com/benchmark/status?commit=f885b5d6f57c70af2fed71630c5e8e73d4cb7b47

[cyberbono3]

I run golangci-lint run
Output: server/rosetta/converter.go:316:2: Consider preallocating rawTxOps(prealloc) var rawTxOps []*rosettatypes.Operation ^ server/rosetta/converter.go:342:2: Consider preallocatingops(prealloc) var ops []*rosettatypes.Operation
How can I handle this? I have not modified rosetta package

[alessio]

I run golangci-lint run
Output: server/rosetta/converter.go:316:2: Consider preallocating rawTxOps(prealloc) var rawTxOps []*rosettatypes.Operation ^ server/rosetta/converter.go:342:2: Consider preallocatingops(prealloc) var ops []*rosettatypes.Operation
How can I handle this? I have not modified rosetta package

At times new linter releases break with past releases.
Feel free to add //nolint: prealloc at server/rosetta/converter.go:342.

As a word of advice: instead of running golangci-lint run I'd advise to just type make lint. Bonus point for running make format too :)

[amaury1093]

tACK, thanks @cyberbono3 for this PR!

I tested:

simd config
simd config node
simd config node "some value" # set some real node

simd q staking validators # uses node from config file
simd q staking validators --node # uses node from flag

simd config node "some value" --home ~/.test # changes value in ~/.test
simd q staking validators --home ~/.test # uses node from ~/.test config file

I left some cosmetic changes suggestions.

[amaury1093]

Can L96-L99 call this function too?

[orijbot]

Benchmark beginning. Status page: https://github.orijtech.com/benchmark/status?commit=fc5b76a9aeb6e3bd800ae6b33c9ea58b1641b3ff

[orijbot]

Benchmark finished. See the result: https://github.orijtech.com/benchmark/result?id=d40aaeabf0b44e7aab19a368c7618c7a

[orijbot]

Benchmark finished. See the result: https://github.orijtech.com/benchmark/result?id=f5c829c39c1a459581f2b427710d31d4

[orijbot]

Benchmark beginning. Status page: https://github.orijtech.com/benchmark/status?commit=32b2d153507d8ee02ce03dc44cf0ba0335283f08

[amaury1093]

@cyberbono3 Could you fix the tests? I believe the PR's almost ready to be merged!

[cyberbono3]

I believe all tests pass except rosetta and codecov. I would appreciate your help to fix them.

[amaury1093]

The rosetta test needs to be fixed #8772
I never look at the codecov check, only the comment (e.g. #8953 (comment)) and it looks good.

Putting automerge on then!

[alessio]

The rosetta test needs to be fixed #8772

CC'ing @fdymylja @jgimeno

[amaury1093]

@Mergifyio backport release/v0.42.x

[mergify]

Command backport release/v0.42.x: failure

No backport have been created
GitHub App like Mergify are not allowed to create pull request where .github/workflows is changed.