Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ServiceMsgs from ADR-031 #9139

Merged
merged 56 commits into from
Apr 30, 2021
Merged
Changes from 1 commit
Commits
Show all changes
56 commits
Select commit Hold shift + click to select a range
f1398cb
wip
aaronc Apr 12, 2021
b54d71f
wip
aaronc Apr 12, 2021
03a358d
wip
aaronc Apr 12, 2021
2a6223e
wip on refactoring adr 031 type URLs
aaronc Apr 12, 2021
559fc54
Fix msg_service_router
amaury1093 Apr 19, 2021
f2d8355
Fix gov client queries
amaury1093 Apr 19, 2021
d5c6ce9
Fix some modules tests
amaury1093 Apr 19, 2021
569f777
Remove all instances of "*.Msg/*"
amaury1093 Apr 19, 2021
19720e7
Merge branch 'master' into am/adr-31-type-url
amaury1093 Apr 19, 2021
c52587c
Uncomment code
amaury1093 Apr 19, 2021
aa30868
Remove commented code
amaury1093 Apr 19, 2021
2919375
// simulation.NewWeightedOperation(
amaury1093 Apr 19, 2021
488dc62
Fix CopyTx
amaury1093 Apr 19, 2021
72c0cbc
Fix more tests
amaury1093 Apr 19, 2021
04ba707
Fix x/gov test
amaury1093 Apr 19, 2021
5f543a4
proto.MessageName->sdk.MsgName
amaury1093 Apr 20, 2021
6d1b1cc
Fix authz tests
amaury1093 Apr 20, 2021
16b72f1
Merge branch 'master' into am/adr-31-type-url
amaury1093 Apr 20, 2021
d4130c2
Use MsgRoute in feegrant and staking/authz
amaury1093 Apr 20, 2021
5f4a19c
Fix more tests
amaury1093 Apr 20, 2021
d5a2982
Fix sims?
amaury1093 Apr 20, 2021
9743b9e
Add norace tag
amaury1093 Apr 20, 2021
a323bff
Add CL
amaury1093 Apr 20, 2021
14acc84
rebuild rosetta api test data
Apr 20, 2021
0e57b6f
Update ADR
amaury1093 Apr 21, 2021
0840c18
Rename MsgRoute -> MsgTypeURL
amaury1093 Apr 21, 2021
5cb4301
Fix codec registration
amaury1093 Apr 21, 2021
fc37733
Remove sdk.GetLegacySignBytes
amaury1093 Apr 21, 2021
5d1836b
Update types/tx_msg.go
amaury1093 Apr 21, 2021
fcaedf9
Update x/authz/simulation/operations.go
amaury1093 Apr 21, 2021
7904aef
Move LegacyMsg to legacytx
amaury1093 Apr 21, 2021
b2bf609
Merge branch 'am/adr-31-type-url' of ssh://github.com/cosmos/cosmos-s…
amaury1093 Apr 21, 2021
77e20c2
Update CHANGELOG.md
amaury1093 Apr 22, 2021
3cac0e6
Remove NewAnyWithCustomTypeURL
amaury1093 Apr 22, 2021
113ef64
Keep support for ServiceMsgs
amaury1093 Apr 22, 2021
1c3886d
Merge branch 'master' into am/adr-31-type-url
amaury1093 Apr 22, 2021
09e81a2
Fix TxBody UnpackInterfaces
amaury1093 Apr 22, 2021
7e05b80
Fix test
amaury1093 Apr 22, 2021
68b7e5f
Address review
amaury1093 Apr 23, 2021
bb33c2b
Merge branch 'master' into am/adr-31-type-url
amaury1093 Apr 23, 2021
c2a024d
Merge branch 'master' of ssh://github.com/cosmos/cosmos-sdk into am/a…
amaury1093 Apr 27, 2021
f25b2c6
Remove support for ServiceMsg typeURLs
amaury1093 Apr 27, 2021
31e5c2a
Fix lint
amaury1093 Apr 27, 2021
d6ab3eb
Update changelog
amaury1093 Apr 27, 2021
3e7d3ae
Fix tests
amaury1093 Apr 27, 2021
2000ebf
Use sdk.MsgTypeURL everywhere
amaury1093 Apr 27, 2021
a688c73
Fix tests
amaury1093 Apr 27, 2021
666fe92
Fix rosetta, run make rosetta-data
amaury1093 Apr 27, 2021
aa2b26c
Fix rosetta thanks to froydi
amaury1093 Apr 27, 2021
249f857
Merge branch 'master' of ssh://github.com/cosmos/cosmos-sdk into am/a…
amaury1093 Apr 27, 2021
d2a8ae5
Merge branch 'master' of ssh://github.com/cosmos/cosmos-sdk into am/a…
amaury1093 Apr 29, 2021
cd4bc02
Address reviews
amaury1093 Apr 29, 2021
774a4ab
Fix test
amaury1093 Apr 29, 2021
d3c3381
Remove stray log
amaury1093 Apr 30, 2021
98ad2b7
Merge branch 'master' of ssh://github.com/cosmos/cosmos-sdk into am/a…
amaury1093 Apr 30, 2021
e95ae32
Update CL
amaury1093 Apr 30, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove sdk.GetLegacySignBytes
amaury1093 committed Apr 21, 2021
commit fc37733aa24af053c7a2323a2baf7860438a4a58
5 changes: 0 additions & 5 deletions types/tx_msg.go
Original file line number Diff line number Diff line change
@@ -95,11 +95,6 @@ type TxDecoder func(txBytes []byte) (Tx, error)
// TxEncoder marshals transaction to bytes
type TxEncoder func(tx Tx) ([]byte, error)

func GetLegacySignBytes(msg Msg) []byte {
legacyMsg := msg.(LegacyMsg)
return legacyMsg.GetSignBytes()
}

// MsgName returns the protobuf MessageName of a sdk.Msg.
func MsgName(msg Msg) string {
amaury1093 marked this conversation as resolved.
Show resolved Hide resolved
return proto.MessageName(msg)
2 changes: 1 addition & 1 deletion x/auth/legacy/legacytx/stdsign.go
Original file line number Diff line number Diff line change
@@ -38,7 +38,7 @@ func StdSignBytes(chainID string, accnum, sequence, timeout uint64, fee StdFee,
// If msg is a legacy Msg, then GetSignBytes is implemented.
// If msg is a ServiceMsg, then GetSignBytes has graceful support of
// calling GetSignBytes from its underlying Msg.
msgsBytes = append(msgsBytes, json.RawMessage(sdk.GetLegacySignBytes(msg)))
msgsBytes = append(msgsBytes, json.RawMessage(msg.(sdk.LegacyMsg).GetSignBytes()))
}

bz, err := legacy.Cdc.MarshalJSON(StdSignDoc{