-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: grpc-web add CORS handler #9493
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9493 +/- ##
==========================================
- Coverage 60.59% 60.58% -0.01%
==========================================
Files 589 589
Lines 37211 37218 +7
==========================================
+ Hits 22547 22548 +1
- Misses 12721 12726 +5
- Partials 1943 1944 +1
|
Co-authored-by: Aleksandr Bezobchuk <[email protected]>
Co-authored-by: Aleksandr Bezobchuk <[email protected]>
Co-authored-by: Aleksandr Bezobchuk <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@aleem1314 did you get a chance to test this manually? I'm okay to merge this if it's tested (or else we need to add another item in regen-network/regen-ledger#352) |
Yes. I've tested manually. Here is a client if anyone wants to test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks a lot @aleem1314! Could you add a changelog entry? Feel free to put automerge right after
Description
Closes: #9467
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change