-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement ics06 solomachine client #676
Conversation
…and improve performance.
…tate.rs and implement Ics2ClientState for ClientState class.
…rface more cleanly.
…nd a basic validation function.
…us-network/cosmos-rust repo (new-proto-v0.12.0 branch).
…te`. Updated the proto file imports in all related files.
…and adding error handling.
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #676 +/- ##
==========================================
- Coverage 72.99% 69.03% -3.97%
==========================================
Files 113 135 +22
Lines 15304 16182 +878
==========================================
Hits 11171 11171
- Misses 4133 5011 +878
☔ View full report in Codecov by Sentry. |
… with `RawSmClientState` and `RawSmConsensusState`, replace `RawSolHeader` and `RawSolMisbehaviour` with `RawSmHeader` and `RawSmMisbehaviour` respectively.
…er; Add Display implementation for signature and data; Add Display implementation for DataType.
… assert timestamp.
Hey @DaviRain-Su this is a great initiative! However, since we implemented ADR 4, light clients no longer need to live in ibc-rs. The ibc-rs team currently maintains the tendermint light client because our team has that expertise, but the goal is really to not have to maintain every light client out there. Here's what I suggest:
Also note that with #296, there will be breaking changes to the |
I move this code to https://github.com/octopus-network/ics06-solomachine |
Awesome! Is the implementation complete? If so, then we'll add a reference to it in our README |
Have not, just on working. breaking on lastet implement verifySignature function. |
I'll close this PR then, and please open a new issue (requesting that we add your crate to our README) when your implementation is ready! |
Closes: #641
Description
The goal of this PR is to implement the ics06 solomachine client in
ibc-go
. During the process, I used some types from the cosmos-rust repository, but using types from this repository resulted in version mismatch issues betweenibc-proto
andcosmos-sdk-proto
. So, my solution was to replace the proto used in thecosmrs
repository withibc-proto
.Here are some issues encountered:
cosmrs
does not supportno-std
, enableno-std
and replatecosmos-sdk-proto
toibc-proto
cosmos-rust#404ibc-proto
andcosmos-sdk-proto,
Fix Merge the files generated by cosmos-sdk-proto into ibc-proto-rs enable to support no-std ibc-proto-rs#102 enableno-std
and replatecosmos-sdk-proto
toibc-proto
cosmos-rust#404tx::signing
types are not implemented incosmrs
. Add cosmos signing type cosmos-rust#405PR author checklist:
unclog
.docs/
).Reviewer checklist:
Files changed
in the GitHub PR explorer.