feat!: remove vscmatured packets #2372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
C:Testing
|
e2e tests need to be fixed |
|
@bermuell could you please fix the e2e tests? |
This reverts commit 89b1d05.
MSalopek
approved these changes
Nov 7, 2024
| @@ -29,15 +41,6 @@ message GenesisState { | |||
| string provider_channel_id = 3; | |||
| // true for new chain, false for chain restart. | |||
| bool new_chain = 4; | |||
| // !!! DEPRECATED !!! ProviderClientState is deprecated. Use provider.client_state instead | |||
There was a problem hiding this comment.
Removing this requires that we have yet another consumer genesis migration CLI command.
Could we avoid this change and simply mark it as no-op?
Or is it so that the provider hasn't even returned these fields for a while now?
There was a problem hiding this comment.
The provider doesn't return these fields for a while.
provider_client_state,provider_consensus_stateandinitial_val_setare part of the ProviderInfomaturing_packetsis not return by the provider as it's empty for new consumer modules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #2281
Consumer-side changes for removal of VSCMaturedPackets (see ADR 018).
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if the change is state-machine breakingCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!the type prefix if the change is state-machine breaking