feat: improve rosetta-ci test (#71)

* added makefile step for test-rosetta-ci * downsized github workflow * Update Makefile Co-authored-by: Ezequiel Raynaudo <[email protected]> * fixed makefile message * debugging workflow * debug * debug * debug * merge with main * removed merge typo * added checkout to cosmos-sdk versioning * fix makefile typo --------- Co-authored-by: Ezequiel Raynaudo <[email protected]>
cosmos · Jan 18, 2024 · 47afcef · 47afcef
1 parent f514fd1
commit 47afcef
Show file tree

Hide file tree

Showing 10 changed files with 30 additions and 106 deletions.
diff --git a/.github/issue_labeler.yml b/.github/issue_labeler.yml
diff --git a/.github/pr_labeler.yml b/.github/pr_labeler.yml
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -37,9 +37,6 @@ jobs:
             **/go.sum
             **/Makefile
             Makefile
-        ###################
-        #### Build App ####
-        ###################
       - name: Build
         if: env.GIT_DIFF
         run: GOARCH=${{ matrix.go-arch }} make build
@@ -48,4 +45,4 @@ jobs:
         ###################
       - name: Build Rosetta
         if: env.GIT_DIFF
-        run: GOARCH=${{ matrix.go-arch }} make rosetta
+        run: GOARCH=${{ matrix.go-arch }} make build
diff --git a/.github/workflows/pr_labeler.yml b/.github/workflows/pr_labeler.yml
diff --git a/.github/workflows/rosetta-cli-test.yaml b/.github/workflows/rosetta-cli-test.yaml
@@ -19,41 +19,8 @@ jobs:
       - uses: actions/setup-go@v5
         with:
           go-version: '^1.21.1'
-      - name: Get cosmos-sdk repo
-        uses: actions/checkout@v4
-        with:
-          repository: cosmos/cosmos-sdk
-          ref: main
-          path: './cosmos-sdk'
-      - name: set up simapp
-        run:
-          cd cosmos-sdk && 
-          make build && 
-          export SIMD_BIN=./build/simd &&
-          make init-simapp
-      - name: Run simapp
-        run: ./cosmos-sdk/build/simd start &
-      - name: Wait for simd to boot up for 2 mins and produce blocks
-        run: sleep 120s
-        shell: bash
-      - name: Check blockchain status
-        run: curl localhost:26657/status
-      - name: Build Rosetta
-        run: go mod tidy && make rosetta && make plugin
-      - name: Run Rosetta service
-        run: ./rosetta --blockchain "cosmos" --network "cosmos" --tendermint "tcp://localhost:26657" --addr "localhost:8080" --grpc "localhost:9090" &
-      - name: Wait for rosetta boot up for 30 secs
-        run: sleep 30s
-        shell: bash
-      - name: Check rosetta status
-        run: curl localhost:8080/block
-      - name: Generate wallets and transactions
-        run:
-          export SIMD_BIN=./cosmos-sdk/build/simd &&
-          chmod +x ./tests/rosetta-cli/data.sh &&
-          ./tests/rosetta-cli/data.sh
-        shell: bash
-      - name: Test rosetta through Rosetta-cli
+      - name: Run make test-rosetta-ci
         run:
-          make rosetta-cli
+          COSMOS_SDK_VERSION=v0.50.3
+          make test-rosetta-ci
         shell: bash
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -37,5 +37,4 @@ jobs:
       - name: tests
         if: env.GIT_DIFF
         run: |
-          make plugin && make test
-          go test -mod=readonly -timeout 30m -coverprofile=coverage.out -covermode=atomic ./...
+          make plugin && make test
diff --git a/Makefile b/Makefile
@@ -1,19 +1,25 @@
 #!/usr/bin/make -f
 
-all: build
+all: build plugin
 
 build:
-	cd plugins/cosmos-hub && make plugin
-	go build -mod=readonly ./cmd/rosetta
-
-rosetta:
 	go build -mod=readonly ./cmd/rosetta
 
 plugin:
 	cd plugins/cosmos-hub && make plugin
 
+docker:
+	docker build . --tag rosetta
+
 test:
-	go test -mod=readonly ./...
+	go test -mod=readonly -timeout 30m -coverprofile=coverage.out -covermode=atomic ./...
+
+test-rosetta-ci:
+	sh ./scripts/simapp-start-node.sh
+	make build && make plugin
+	./rosetta --blockchain "cosmos" --network "cosmos" --tendermint "tcp://localhost:26657" --addr "localhost:8080" --grpc "localhost:9090" &
+	sleep 30
+	export SIMD_BIN=./cosmos-sdk/build/simd && sh ./tests/rosetta-cli/rosetta-cli-test.sh
 
 ###############################################################################
 ###                                Linting                                  ###
@@ -31,9 +37,3 @@ lint-fix:
 	@./scripts/go-lint-all.bash --fix
 
 .PHONY: all build rosetta test lint lint-fix
-
-docker:
-	docker build . --tag rosetta
-
-rosetta-cli:
-	./tests/rosetta-cli/rosetta-cli-test.sh
diff --git a/README.md b/README.md
@@ -18,7 +18,7 @@ Install Rosetta standalone server with the following command:
 go install github.com/cosmos/rosetta
 ```
 
-Alternatively, for building from source, simply run `make rosetta`. The binary will be located in the root folder.
+Alternatively, for building from source, simply run `make build`. The binary will be located in the root folder.
 
 ### Native - As a node command
 

diff --git a/scripts/simapp-start-node.sh b/scripts/simapp-start-node.sh
@@ -0,0 +1,12 @@
+git clone https://github.com/cosmos/cosmos-sdk.git
+# shellcheck disable=SC2164
+cd cosmos-sdk
+git checkout "$COSMOS_SDK_VERSION"
+make build
+export SIMD_BIN=./build/simd
+chmod 777 ./scripts/init-simapp.sh
+sh ./scripts/init-simapp.sh --just-print
+$SIMD_BIN start &
+until curl --output /dev/null --silent --head --fail http://localhost:26657/health; do
+  sleep 1
+done
diff --git a/tests/rosetta-cli/data.sh b/tests/rosetta-cli/data.sh