Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

70~80% Korean Localization of Menu #317

Closed
wants to merge 7 commits into from
Closed

70~80% Korean Localization of Menu #317

wants to merge 7 commits into from

Conversation

kabbala
Copy link

@kabbala kabbala commented Dec 2, 2014

I translated Menu to Korean. about 70~80% completed.

would you merge it to original code?

@1024jp
Copy link
Member

1024jp commented Dec 2, 2014

CotEditor requires a good quality also for localizations. If the localization completely finished, I’ll marge it with pleasure. But only the main menu is not acceptable.

To localize CotEditor, you also need to localize OgreKit framework which is used on the CotEditor's find panel and the find menu. Unfortunately, OgreKit has no Korean localization currently, however I know there is a pull-request for Korean localization which has not been merged to the original repository yet. I (or you) can ask the person who made the p-r for using this localisation also in CotEditor. If it accepted I’ll marge it to our forked OgreKit repo.

If you feel translating all xib files is too much work, you can also wait until CotEditor migrates to using the base internationalization (#256). I believe it’s easier for all those who localize our editor . I’ll migrate it within this year after the release of CotEditor 2.0.3.

@kabbala
Copy link
Author

kabbala commented Dec 2, 2014

Thank you for kind answering.

I will follow your advice.

答えてくれてありがとうございます。

アドバイスに従います。

@kabbala kabbala closed this Dec 2, 2014
1024jp added a commit that referenced this pull request Dec 6, 2014
@1024jp
Copy link
Member

1024jp commented Dec 6, 2014

I've implemented the Korean localization to OgreKit ;)

@1024jp 1024jp added the localization tasks related to application localization label May 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
localization tasks related to application localization
Development

Successfully merging this pull request may close these issues.

2 participants