Avoid NPE potentially caused by race condition #37
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Periodically, we are seeing a
java.lang.NullPointerException
with the following stack trace:As far as I can tell, there must be some sort of race going on where the second call to
getSk()
returnsnull
even after the first check passes, causing the de-reference of theisValid()
method to throw the NPE. I am wondering if the real fix is to put some sort of lock around the SK or have the getSk() method return a copy to avoid this issue. It's unclear what the impact is when this happens, but I suspect it is causing an operation to fail/not be executed because the runtime exception.