Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CBG-4336: add updated at field for persisted configs #7265

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Conversation

gregns1
Copy link
Contributor

@gregns1 gregns1 commented Jan 7, 2025

CBG-4336

  • Add updated at timestamp to persisted configs
  • The following configs are included:
    • Registry
    • Db configs
    • Replication configs
    • User and role docs

Pre-review checklist

  • Removed debug logging (fmt.Print, log.Print, ...)
  • Logging sensitive data? Make sure it's tagged (e.g. base.UD(docID), base.MD(dbName))
  • Updated relevant information in the API specifications (such as endpoint descriptions, schemas, ...) in docs/api

Integration Tests

@gregns1 gregns1 self-assigned this Jan 7, 2025
@bbrks
Copy link
Member

bbrks commented Jan 7, 2025

@JRascagneres Can you review and make sure the updated_at name and format/UTC aligns with stuff on your side? And input on whether created_at is necessary as well.

@bbrks bbrks requested review from JRascagneres and bbrks January 7, 2025 15:03
@bbrks
Copy link
Member

bbrks commented Jan 7, 2025

As discussed - add a created_at field as well, but don't care about timestamp format - keep that as-is.

@JRascagneres JRascagneres removed their request for review January 7, 2025 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants