Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CBG-4407 synchronously stop xdcr from CBS #7270

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Conversation

torcolvin
Copy link
Collaborator

This increases the time of the XDCR package by about 20% on my computer.

Greps the goxdcr.log file for the magic string. Tested on local Linux, docker linux, cbdinocluster multi node setup (where this is not supported). I can not successfully run Couchbase Server on Mac for reasons that are not related to this ticket and I am reluctant to sink more time into debugging right now.

This will require setting export SG_TEST_COUCHBASE_SERVER_DOCKER_NAME="couchbase" if couchbase server docker is used, but the error message should say that.

Pre-review checklist

  • Removed debug logging (fmt.Print, log.Print, ...)
  • Logging sensitive data? Make sure it's tagged (e.g. base.UD(docID), base.MD(dbName))
  • Updated relevant information in the API specifications (such as endpoint descriptions, schemas, ...) in docs/api

Integration Tests

@torcolvin torcolvin merged commit 7dadb16 into release/anemone Jan 9, 2025
36 checks passed
@torcolvin torcolvin deleted the CBG-4407 branch January 9, 2025 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants