Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for Ubuntu 22.04 Jammy Jellyfish #33

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Added support for Ubuntu 22.04 Jammy Jellyfish #33

wants to merge 1 commit into from

Conversation

eNBeWe
Copy link

@eNBeWe eNBeWe commented May 28, 2022

  • Changed the default ubuntu release to 22.04 (jammy)
  • Added option --focal for 20.04 (focal)
  • Implemented extracting boot partitions from existing cd image
  • Changed xorriso call for image creation to conform to 22.04 layout

Signed-off-by: Nis Wechselberg [email protected]

@eNBeWe eNBeWe mentioned this pull request May 28, 2022
Open
dcd-arnold
dcd-arnold reviewed May 30, 2022
View reviewed changes
Copy link

@dcd-arnold dcd-arnold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This (with the changes suggested) yields a booting usb drive! 🙇‍♂️

ubuntu-autoinstall-generator.sh Outdated Show resolved Hide resolved
@eNBeWe
Support for 22.04
da38d98 
* Changed the default ubuntu release to 22.04 (jammy)
* Added option --focal for 20.04 (focal)
* Implemented extracting boot partitions from existing cd image
* Changed xorriso call for image creation to conform to 22.04 layout

Signed-off-by: Nis Wechselberg <[email protected]>
@smcoder0707
Copy link

Hi,

This is failing for me with the following error. Can you re-check?

[2022-06-15 00:46:57] 📦 Repackaging extracted files into an ISO image...
xorriso 1.4.8 : RockRidge filesystem manipulator, libburnia project.

Drive current: -outdev 'stdio:/root/cidata/autoinstall-iso-generator/ubuntu-jammy-autoinstall-2022-06-15.iso'
Media current: stdio file, overwriteable
Media status : is blank
Media summary: 0 sessions, 0 data blocks, 0 data, 20.2g free
xorriso : WARNING : -volid text does not comply to ISO 9660 / ECMA 119 rules
xorriso : FAILURE : -append_partition: Partition type '28732ac11ff8d211ba4b00a0c93ec93b' is out of range (0x00...0xff)
xorriso : aborting : -abort_on 'FAILURE' encountered 'FAILURE'
[2022-06-15 00:46:57] 🚽 Deleted temporary working directory /tmp/tmp.ZiI7cxVgQb

@NetForces
Copy link

@smcoder0707 what is your full command line ?

Also does it also fail with the released code (not the code in this branch) ?

@smcoder0707
Copy link

smcoder0707 commented Jun 14, 2022 •
edited
Loading

@smcoder0707 what is your full command line ?

Also does it also fail with the released code (not the code in this branch) ?

  • Jammy Jellyfish 22.04 fails
    bash /root/cidata/autoinstall-iso-generator/ubuntu-autoinstall-generator.sh --all-in-one --no-md5 --user-data /root/cidata/output//seed-data//user-data --meta-data /root/cidata/output//seed-data//meta-data --destination /root/cidata/output//ubuntu-autoinstall-2022-06-15.iso

  • Output

[2022-06-15 00:46:57] 📦 Repackaging extracted files into an ISO image...
xorriso 1.4.8 : RockRidge filesystem manipulator, libburnia project.

Drive current: -outdev 'stdio:/root/cidata/autoinstall-iso-generator/ubuntu-jammy-autoinstall-2022-06-15.iso'
Media current: stdio file, overwriteable
Media status : is blank
Media summary: 0 sessions, 0 data blocks, 0 data, 20.2g free
xorriso : WARNING : -volid text does not comply to ISO 9660 / ECMA 119 rules
xorriso : FAILURE : -append_partition: Partition type '28732ac11ff8d211ba4b00a0c93ec93b' is out of range (0x00...0xff)
xorriso : aborting : -abort_on 'FAILURE' encountered 'FAILURE'
[2022-06-15 00:46:57] 🚽 Deleted temporary working directory /tmp/tmp.ZiI7cxVgQb

  • Focal 20.04 works fine
    bash /root/cidata/autoinstall-iso-generator/ubuntu-autoinstall-generator.sh --focal --all-in-one --no-md5 --user-data /root/cidata/output//seed-data//user-data --meta-data /root/cidata/output//seed-data//meta-data --destination /root/cidata/output//ubuntu-autoinstall-2022-06-15.iso

  • Output

[2022-06-15 01:13:15] 📦 Repackaging extracted files into an ISO image...
xorriso 1.4.8 : RockRidge filesystem manipulator, libburnia project.

xorriso : NOTE : Local character set is now assumed as: 'utf-8'
Drive current: -outdev 'stdio:/root/cidata/autoinstall-iso-generator/ubuntu-focal-autoinstall-2022-06-15.iso'
Media current: stdio file, overwriteable
Media status : is blank
Media summary: 0 sessions, 0 data blocks, 0 data, 19.0g free
xorriso : WARNING : -volid text does not comply to ISO 9660 / ECMA 119 rules
Added to ISO image: directory '/'='/tmp/tmp.DJ8GSmIcuU'
xorriso : UPDATE : 747 files added in 1 seconds
xorriso : UPDATE : 747 files added in 1 seconds
xorriso : NOTE : Copying to System Area: 432 bytes from file '/usr/lib/ISOLINUX/isohdpfx.bin'
libisofs: WARNING : Cannot add /dists/stable to Joliet tree. Symlinks can only be added to a Rock Ridge tree.
libisofs: WARNING : Cannot add /dists/unstable to Joliet tree. Symlinks can only be added to a Rock Ridge tree.
libisofs: WARNING : Cannot add /ubuntu to Joliet tree. Symlinks can only be added to a Rock Ridge tree.
libisofs: NOTE : Automatically adjusted MBR geometry to 1018/82/32
libisofs: NOTE : Aligned image size to cylinder size by 208 blocks
xorriso : UPDATE :  0.43% done
xorriso : UPDATE :  6.49% done
xorriso : UPDATE :  17.93% done
xorriso : UPDATE :  29.15% done, estimate finish Wed Jun 15 01:13:25 2022
xorriso : UPDATE :  40.25% done, estimate finish Wed Jun 15 01:13:25 2022
xorriso : UPDATE :  50.82% done, estimate finish Wed Jun 15 01:13:25 2022
xorriso : UPDATE :  60.53% done, estimate finish Wed Jun 15 01:13:25 2022
xorriso : UPDATE :  69.30% done, estimate finish Wed Jun 15 01:13:25 2022
xorriso : UPDATE :  79.22% done, estimate finish Wed Jun 15 01:13:25 2022
xorriso : UPDATE :  88.86% done, estimate finish Wed Jun 15 01:13:26 2022
xorriso : UPDATE :  98.58% done
ISO image produced: 667808 sectors
Written to medium : 667808 sectors at LBA 0
Writing to 'stdio:/root/cidata/autoinstall-iso-generator/ubuntu-focal-autoinstall-2022-06-15.iso' completed successfully.

[2022-06-15 01:13:26] 👍 Repackaged into /root/cidata/autoinstall-iso-generator/ubuntu-focal-autoinstall-2022-06-15.iso
[2022-06-15 01:13:26] ✅ Completed.
[2022-06-15 01:13:26] 🚽 Deleted temporary working directory /tmp/tmp.DJ8GSmIcuU

Also does it also fail with the released code (not the code in this branch) ?

Not sure what you mean but the script from the original repo worked perfectly. Then I applied this patch from your pull request to modify the main script and now it fails only for ubuntu 22.04.

Hope this information is sufficient.

@eNBeWe
Copy link
Author

eNBeWe commented Jun 14, 2022 •
edited
Loading

Have you tried to use release version (parameter -r)?
First glance looks like there might be something changed in the source iso that changed partition GUIDs.
EDIT: Just rechecked with the daily iso and it worked fine out of the box ... Not sure what is happening

@smcoder0707
Copy link

Have you tried to use release version (parameter -r)? First glance looks like there might be something changed in the source iso that changed partition GUIDs. EDIT: Just rechecked with the daily iso and it worked fine out of the box ... Not sure what is happening

Yes, just tried release version as well and it failed with similar/same error. The exact error is

xorriso : FAILURE : -append_partition: Partition type '28732ac11ff8d211ba4b00a0c93ec93b' is out of range (0x00...0xff)

I'm using "Ubuntu 18.04.6 LTS" within a HyperV VM if that matters. I've just cloned your code from here and did a fresh test. But It's all error.

@smcoder0707
Copy link

smcoder0707 commented Jun 14, 2022 •
edited
Loading

Alright, turns out my VM has some problem. Not sure what is the problem but I tried another freshly installed VM and that worked perfectly.

@Tombar
Copy link

Tombar commented Jul 27, 2022

Just tried it out and was able to build an iso with, but unfortunately it looks like the ISO doesn't boot on a uefi enabled motherboard?

@tuxick
Copy link

tuxick commented Nov 16, 2022

Installing generated iso in kvm worked for me.

@steve-daedilus
Copy link

Looks good. I'm going to look to merge this with my -x function for adding additional files into the custom ISO. Not sure if that would be easier done by bringing this over to my fork or you adding to your fork?
See https://github.com/steve-daedilus/ubuntu-autoinstall-generator

@eNBeWe
Copy link
Author

eNBeWe commented Nov 23, 2022

Not sure how to go ahead. I kind of gave up on this PR and switched to using pxeless.

func0der added a commit to func0der/ubuntu-autoinstall-generator that referenced this pull request Jun 2, 2024
@func0der
Make script work with ubuntu 22.04+
c00c4ab 
Thanks to covertsh#33
@func0der
Copy link

func0der commented Jun 2, 2024

Thanks for this @eNBeWe

It worked with 24.04 desktop (changing some parameters) too. :)

@Tipsmark
Copy link

Thanks for this @eNBeWe

It worked with 24.04 desktop (changing some parameters) too. :)

Could you share the working bits for 24.04? I'll edit to match server then instead of desktop.

@func0der
Copy link

I basically replace the focal parts with 24.04 codenames and version numbers.
Since this project seems dead anyway, I won't bother creating a PR.
Sorry, mate. If I find it (not where it is stored right now), I will put it here.

@steve-daedilus
Copy link

I previously forked and added an extra files switch. If there's some desire to try and update to newer versions with optional support based on a switch or other, I can take a look. I'm fairly sure I did something similar for a work related effort at a former employer not long after my extra files fork.

Feel free to hit me up at https://github.com/steve-daedilus/ubuntu-autoinstall-generator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcd-arnold dcd-arnold dcd-arnold left review comments

@NetForces NetForces NetForces left review comments

@JohannesArtmeier JohannesArtmeier JohannesArtmeier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@eNBeWe @smcoder0707 @NetForces @Tombar @tuxick @steve-daedilus @func0der @Tipsmark @JohannesArtmeier @dcd-arnold