Propagate the surplus capturing JIT-order owners to the solvers #2759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-lord-renkse
commented
May 28, 2024
Comment on lines
+358
to
+359
| receiver: Option<eth::H160>, | ||
| owner: eth::H160, |
There was a problem hiding this comment.
Removed the H160 import and make it all as eth::H160 to keep consistency
m-lord-renkse
force-pushed
the
propagate-surplus-jit-order-owners-to-solvers
branch
from
9b155a9 to
6690e5f
Compare
squadgazzz
approved these changes
May 28, 2024
sunce86
reviewed
May 28, 2024
m-lord-renkse
force-pushed
the
propagate-surplus-jit-order-owners-to-solvers
branch
5 times, most recently
from
fff1c72 to
cae7a0a
Compare
m-lord-renkse
force-pushed
the
propagate-surplus-jit-order-owners-to-solvers
branch
from
cae7a0a to
0b3b110
Compare
fleupold
approved these changes
May 29, 2024
There was a problem hiding this comment.
You probably know, but this will also require a change in https://github.com/gnosis/solvers/blob/ca55c3cca15630891f653bca077a8a0c6b364c39/Cargo.toml#L49
@fleupold yup, the PR is ready, I just need to merge this first and then push the tag. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The solvers would need to know the JIT-order surplus capturing addresses (see e.g. #2715 (comment)). For that the owner addresses are propagated to the solvers in the auction json.
Changes
Propagate the list of surplus capturing JIT-order owners to the solvers in the auction json.
How to test