Newer version of BigButtons doesn't work #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds parsing for several command line parameters which control which buttons are displayed on the page as well as overriding the title of the page. New options: start - start button number end - end button number title - title for page Example URLs which you can use to access this page and display specific buttons: http://192.168.1.10/plugin.php?plugin=fpp-BigButtons&page=bigbuttons.php&nopage=1&start=11&end=18&title=Buttons_11-18
When the font size was changed, an invalid config would be written. If the user did not press the Save button to overwrite this invalid config, then subsequent loads of the config page were unable to overwrite due to loading the invalid config. This patch fixes the issue with the font size so that it is not saved until the save button is clicked and it also provides a workaround for users who already have the invalid config file containing only the word 'null'.
Refactor to allow re-sorting
Add multiple tabs functionality and update for newui
Merge multiple tabs branch into newui branch
This was already in another place, must have been a testing error. This reverts commit bde0fe5.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated BigButtons to the latest version from Github. I can add new tabs at the top of the page, but I am unable to delete tabs or rename them.
I also can't configure a new button on the bottom inside a tab. I can give it a name, but can't configure a command associated with the button. Clicking on the button with a gear inside it does nothing, and I sometimes can see an option to add a command, but it's hard to see due to the white text over gray background.
The older version of BigButtons I never had a problem with, and I can still use it, but I really like the ability to use tabs now, as the older version has a limited to 20 buttons, and I intend to use more if possible.
I also downloaded all of the source files directly from Github and transferred them to FPP via an FTP connection. It was initially installed and updated through the plugin manager from the FPP web interface.
Attached is a screen shot of my issue.