Skip to content

Commit

Permalink
Bump the pip group across 1 directory with 2 updates (#247)
Browse files Browse the repository at this point in the history
* Bump the pip group across 1 directory with 2 updates

Bumps the pip group with 2 updates in the / directory: [clang-tools](https://github.com/cpp-linter/clang-tools-pip) and [cpp-linter](https://github.com/cpp-linter/cpp-linter).


Updates `clang-tools` from 0.12.1 to 0.13.0
- [Release notes](https://github.com/cpp-linter/clang-tools-pip/releases)
- [Commits](cpp-linter/clang-tools-pip@v0.12.1...v0.13.0)

Updates `cpp-linter` from 1.8.1 to 1.10.0
- [Release notes](https://github.com/cpp-linter/cpp-linter/releases)
- [Commits](cpp-linter/cpp-linter@v1.8.1...v1.10.0)

---
updated-dependencies:
- dependency-name: clang-tools
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: pip
- dependency-name: cpp-linter
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: pip
...

Signed-off-by: dependabot[bot] <[email protected]>

* add tool-specific ignore options

resolves #233

* add input for passive reviews

resolves #243

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Brendan <[email protected]>
  • Loading branch information
dependabot[bot] and 2bndy5 authored Jun 8, 2024
1 parent 09a8c47 commit 820b182
Show file tree
Hide file tree
Showing 4 changed files with 35 additions and 4 deletions.
26 changes: 25 additions & 1 deletion action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,20 @@ inputs:
- Prefix a path with a bang (`!`) to make it explicitly _not_ ignored. The order of
multiple paths does _not_ take precedence. The `!` prefix can be applied to
a submodule's path (if desired) but not hidden directories.
- Glob patterns are not supported here. All asterisk characters (`*`) are literal.
- **As of v2.12**, glob patterns are supported here.
All asterisk characters (`*`) were previously literal.
required: false
default: '.github'
ignore-tidy:
description: |-
Use this option to allow clang-tidy to ignore certain paths/files.
See [`ignore`](#ignore) for more details on possible values.
required: false
default: '.github'
ignore-format:
description: |-
Use this option to allow clang-format to ignore certain paths/files.
See [`ignore`](#ignore) for more details on possible values.
required: false
default: '.github'
thread-comments:
Expand Down Expand Up @@ -191,6 +204,11 @@ inputs:
> The [`no-lgtm`](#no-lgtm) option is applicable to Pull Request reviews.
required: false
default: false
passive-reviews:
description: |
Set this option to `true` to prevent Pull Request reviews from approving or requesting changes.
default: false
required: false
jobs:
description: |
The number of jobs to run in parallel.
Expand Down Expand Up @@ -272,11 +290,14 @@ runs:
--no-lgtm=${{ inputs.no-lgtm }} \
--step-summary=${{ inputs.step-summary }} \
--ignore="${{ inputs.ignore }}" \
--ignore-tidy="${{ inputs.ignore-tidy }}" \
--ignore-format="${{ inputs.ignore-format }}" \
--database=${{ inputs.database }} \
--file-annotations=${{ inputs.file-annotations }} \
--extra-arg="${{ inputs.extra-args }}" \
--tidy-review="${{ inputs.tidy-review }}" \
--format-review="${{ inputs.format-review }}" \
--passive-reviews="${{ inputs.passive-reviews }}" \
--jobs=${{ inputs.jobs }}
- name: Setup python venv (Windows)
Expand Down Expand Up @@ -308,11 +329,14 @@ runs:
' --no-lgtm=${{ inputs.no-lgtm }}' +
' --step-summary=${{ inputs.step-summary }}' +
' --ignore="${{ inputs.ignore }}"' +
' --ignore-tidy="${{ inputs.ignore-tidy }}"' +
' --ignore-format="${{ inputs.ignore-format }}"' +
' --database=${{ inputs.database }}' +
' --file-annotations=${{ inputs.file-annotations }}' +
' --extra-arg="${{ inputs.extra-args }}"' +
' --tidy-review="${{ inputs.tidy-review }}"' +
' --format-review="${{ inputs.format-review }}"' +
' --passive-reviews="${{ inputs.passive-reviews }}"' +
' --jobs=${{ inputs.jobs }}'
Invoke-Expression -Command $app
7 changes: 7 additions & 0 deletions docs/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,10 @@ inputs:
required-permission: 'contents: read #file-changes'
ignore:
minimum-version: '1.3.0'
ignore-tidy:
minimum-version: '2.12.0'
ignore-format:
minimum-version: '2.12.0'
thread-comments:
minimum-version: '2.6.2'
required-permission: 'contents: write #thread-comments'
Expand All @@ -40,6 +44,9 @@ inputs:
format-review:
minimum-version: '2.9.0'
required-permission: 'pull-requests: write #pull-request-reviews'
passive-reviews:
minimum-version: '2.12.0'
required-permission: 'pull-requests: write #pull-request-reviews'
jobs:
minimum-version: '2.11.0'
outputs:
Expand Down
2 changes: 1 addition & 1 deletion docs/permissions.md
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ The [`thread-comments`](inputs-outputs.md#thread-comments) feature requires the

## Pull Request Reviews

The [`tidy-review`](inputs-outputs.md#tidy-review) and [`format-review`](inputs-outputs.md#format-review) features require the following permissions:
The [`tidy-review`](inputs-outputs.md#tidy-review), [`format-review`](inputs-outputs.md#format-review), and [`passive-reviews`](inputs-outputs.md#passive-reviews) features require the following permissions:

```yaml
permissions:
Expand Down
4 changes: 2 additions & 2 deletions requirements.txt
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Install clang-tools binaries (clang-format, clang-tidy)
# For details please see: https://github.com/cpp-linter/clang-tools-pip
clang-tools==0.12.1
clang-tools==0.13.0

# cpp-linter core Python executable package
# For details please see: https://github.com/cpp-linter/cpp-linter
cpp-linter==1.8.1
cpp-linter==1.10.0

1 comment on commit 820b182

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented on 820b182 Jun 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cpp-Linter Report ⚠️

Some files did not pass the configured checks!

clang-format reports: 2 file(s) not formatted
  • docs/examples/demo/demo.cpp
  • docs/examples/demo/demo.hpp
clang-tidy reports: 7 concern(s)

Have any feedback or feature suggestions? Share it here.

Please sign in to comment.