Clean up repo, use CPM for dependency management #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maztheman
commented
Dec 7, 2023
maztheman
commented
- Update CMake version to 3.21
- Make this repo able to be pulled in as a dependency via CMake
- Use new compiler and environment detection (from range-v3)
- Use CPM for dependencies
- Fix Github actions to work on Clang 10,11,12,14
- Update CMake version to 3.21 - Make this repo able to be pulled in as a dependency via CMake - Use new compiler and environment detection (from range-v3) - Use CPM for dependencies - Fix Github actions to work on Clang 10,11,12,14
This was referenced Dec 7, 2023
|
vcpkg install in the github action is no longer really needed..but left it in for now |
|
Thanks @maztheman, this is awesome! This needed some attention, I'm happy for the contribution. |
|
I didn't mean to add that second commit, oops. |
glynos
approved these changes
Dec 8, 2023
| @@ -451,8 +475,9 @@ jobs: | |||
| -D skyr_BUILD_DOCS=OFF | |||
| -D skyr_BUILD_EXAMPLES=OFF | |||
| -D skyr_BUILD_V2=${BUILD_V2} | |||
| -D skyr_BUILD_WITH_LLVM_LIBCXX=${USE_LLVM} | |||
| -D SKY_VERBOSE_BUILD=ON | |||
There was a problem hiding this comment.
Should that be "skyr_VERBOSE_BUILD"?
There was a problem hiding this comment.
Looks like the new variables I put in has prefix SKY, but that doesn't seem to be consistent with everything else. Should probably be changed.
Can you rebase and remove it? Then I'll merge |
|
done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.