cpp-redis: allow build as shared library #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lindblandro
suggested changes
Nov 2, 2022
| @@ -141,7 +141,14 @@ configure_file("cpp_redis.pc.in" "${CMAKE_PKGCONFIG_OUTPUT_DIRECTORY}/cpp_redis. | |||
| ### | |||
| # executable | |||
| ### | |||
| if (BUILD_SHARED_LIBS) | |||
There was a problem hiding this comment.
This is already a global CMake option that overrides the default behavior of add_library() if present.
set(BUILD_SHARED_LIBS ON)
add_library(${PROJECT} ${SOURCES})
will build a shared library. The SOVERSION property will need to be added for symlinks to be generated at install time, but the properties can be set even if BUILD_SHARED_LIBS is not set. A valid value for SOVERSION might be the same as VERSION or just PROJECT_VERSION_MAJOR
See https://cmake.org/cmake/help/v3.13/variable/BUILD_SHARED_LIBS.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be very helpful if we could build this library as a shared library (*.so).