Skip to content

Commit

Permalink
Fix npm audit and codecov CI (#328)
Browse files Browse the repository at this point in the history
* npm audit fix
* Use CodeCov GitHub Action in CI instead of npx codecov
* Update checkout and setupnode actions to v4
  • Loading branch information
cmoesel authored Nov 12, 2024
1 parent 94cea07 commit 12a8ce0
Show file tree
Hide file tree
Showing 2 changed files with 35 additions and 26 deletions.
22 changes: 13 additions & 9 deletions .github/workflows/ci-workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@ jobs:
name: Check npm audit
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v1
- uses: actions/setup-node@v1
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: '18.x'
- run: npm audit
Expand All @@ -18,8 +18,8 @@ jobs:
name: Check cql4browsers
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v1
- uses: actions/setup-node@v1
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: '18.x'
- run: ./bin/validate_cql4browsers.sh
Expand All @@ -29,8 +29,8 @@ jobs:
name: Check lint and prettier
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v1
- uses: actions/setup-node@v1
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: '18.x'
- run: npm install
Expand All @@ -42,8 +42,8 @@ jobs:
name: Test on node 18 and ubuntu-latest
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v1
- uses: actions/setup-node@v1
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: '18.x'
- name: Set timezone to America/New_York
Expand All @@ -53,6 +53,10 @@ jobs:
- run: date +"%Y-%m-%d %T"
- run: npm install
- run: ./bin/check_for_nonassertive_tests.sh
- run: npx nyc --reporter=lcov npm test && npx codecov
- run: npx nyc --reporter=lcov npm test
env:
CI: true
- name: Upload coverage to Codecov
uses: codecov/codecov-action@v4
with:
token: ${{ secrets.CODECOV_TOKEN }}
39 changes: 22 additions & 17 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 12a8ce0

Please sign in to comment.