Updated cql-to-elm instructions in README.md #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmoesel
requested changes
Dec 20, 2023
README.md
Outdated
Comment on lines
254
to
309
| "library" : { | ||
| "identifier" : { "id" : "TestSnippet", "version" : "1" }, | ||
| "schemaIdentifier" : { "id" : "urn:hl7-org:elm", "version" : "r1" }, | ||
| "usings" : { | ||
| "def" : [ | ||
| { "localIdentifier" : "System", "uri" : "urn:hl7-org:elm-types:r1" }, | ||
| { "localIdentifier" : "Simple", "uri" : "https://github.com/cqframework/cql-execution/simple", "version" : "1.0.0" } | ||
| ] | ||
| }, | ||
| "statements" : { | ||
| "def" : [ { | ||
| "name" : "Patient", | ||
| "context" : "Patient", | ||
| "expression" : { | ||
| "type" : "SingletonFrom", | ||
| "operand" : { | ||
| "dataType" : "{https://github.com/cqframework/cql-execution/simple}Patient", | ||
| "type" : "Retrieve" | ||
| } | ||
| } | ||
| }, { | ||
| "name" : "AllTrue", | ||
| "context" : "Patient", | ||
| "accessLevel" : "Public", | ||
| "expression" : { | ||
| "type" : "And", | ||
| "operand" : [ | ||
| { "valueType" : "{urn:hl7-org:elm-types:r1}Boolean", "value" : "true", "type" : "Literal" }, | ||
| { "valueType" : "{urn:hl7-org:elm-types:r1}Boolean", "value" : "true", "type" : "Literal" } | ||
| ] | ||
| } | ||
| }, { | ||
| "name" : "SomeTrue", | ||
| "context" : "Patient", | ||
| "accessLevel" : "Public", | ||
| "expression" : { | ||
| "type" : "And", | ||
| "operand" : [ | ||
| { "valueType" : "{urn:hl7-org:elm-types:r1}Boolean", "value" : "true", "type" : "Literal" }, | ||
| { "valueType" : "{urn:hl7-org:elm-types:r1}Boolean", "value" : "false", "type" : "Literal" } | ||
| ] | ||
| } | ||
| }, { | ||
| "name" : "AllFalse", | ||
| "context" : "Patient", | ||
| "accessLevel" : "Public", | ||
| "expression" : { | ||
| "type" : "And", | ||
| "operand" : [ | ||
| { "valueType" : "{urn:hl7-org:elm-types:r1}Boolean", "value" : "false", "type" : "Literal" }, | ||
| { "valueType" : "{urn:hl7-org:elm-types:r1}Boolean", "value" : "false", "type" : "Literal" } | ||
| ] | ||
| } | ||
| } | ||
| ]} | ||
| } | ||
| } |
There was a problem hiding this comment.
This indent, on the other hand, looks good. I'm not sure how/why we had a three-space indent before. Thanks for fixing it!
|
Thanks, @sorliog. It looks like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull requests into cql-execution require the following.
Submitter and reviewer should ✔ when done.
For items that are not-applicable, mark "N/A" and ✔.
CDS Connect and Bonnie are the main users of this repository.
It is strongly recommended to include a person from each of those projects as a reviewer.
Summary
Instructions for translating CQL to ELM in README.md are out of date with clinical_quality_language. This update changes the documentation to use the
cql-to-elm-cliexecutable instead of thecql-to-elmlibrary.Submitter:
npm run test:plusto run tests, lint, and prettier)cql4browsers.jsbuilt withnpm run build:browserifyif source changed.Reviewer:
Name: