Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added maven-shade-plugin to build uber jar with all dependencies #11

Merged
merged 9 commits into from
Oct 19, 2022

Conversation

LumnitzF
Copy link

Fixes #10

@LumnitzF LumnitzF requested a review from agoeb October 18, 2022 15:32
@agoeb
Copy link
Contributor

agoeb commented Oct 19, 2022

Great work! The jar builds, is usable on my machine, and works as expected. I just noticed a few things about the build itself that might need a little improvement:

  • There are deprecation warnings about "actions/checkout" and "actions/upload-artifact". Please update the respective versions.
  • The UPX action issues a deprecation warning about the "file" parameter and suggests using "files" instead. Could you maybe switch that as well?
  • The "build-shaded" step produces an artifact called "target-shaded". To me, "shaded" seems like an implementation detail, and what I am looking for is a Jar. Could you rename the target to "target-jar" or "target-java" please?
  • I'd like the Jar to be publicly downloadable, so it might be a good idea to include it into the "release" step. WDYT?

@LumnitzF
Copy link
Author

Applied the changes you mentioned.
The final jar is also included in the release step, however I can't/don't know how to test it

Copy link
Contributor

@agoeb agoeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few further remarks, including an important one regarding job dependencies.
Sorry if I come across a bit picky, but I suppose fixing stuff in the workflow is cheapest while you're at it anyways. :-)

.github/workflows/actions.yml Show resolved Hide resolved
.github/workflows/actions.yml Outdated Show resolved Hide resolved
.github/workflows/actions.yml Outdated Show resolved Hide resolved
.github/workflows/actions.yml Show resolved Hide resolved
@LumnitzF LumnitzF requested a review from agoeb October 19, 2022 15:33
Copy link
Contributor

@agoeb agoeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@agoeb agoeb merged commit 3d2b5c0 into master Oct 19, 2022
@agoeb agoeb deleted the shaded_jar branch October 19, 2022 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide build-breaker as fat-jar
2 participants