Ts-40621 jacoco agent proxy settings are needed before loading config from teamscale #580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 10, 2024 12:02
…setting the proxy options
flameJam
commented
Oct 10, 2024
agent/src/test/java/com/teamscale/jacoco/agent/options/AgentOptionsTest.java
Outdated
Show resolved
Hide resolved
Raphael-N
reviewed
Oct 14, 2024
agent/src/main/java/com/teamscale/jacoco/agent/options/AgentOptionsParser.java
Outdated
Show resolved
Hide resolved
| options.getTeamscaleProxyOptions(ProxySystemProperties.Protocol.HTTPS).putTeamscaleProxyOptionsIntoSystemProperties(); | ||
| } | ||
|
|
||
| private void handleConfigId(AgentOptions options) throws AgentOptionReceiveException, AgentOptionParseException { |
There was a problem hiding this comment.
The new name is not fully fitting, because it also handles the config-file option 🤔
There was a problem hiding this comment.
I just split it into two methods since the config-id and the config-file are not directly related. Wdyt?
Raphael-N
deleted the
ts/40621_jacoco_agent_proxy_settings_are_needed_before_loading_config_from_teamscale
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue TS-XXXXX
Please respect the vote of the Teamscale bot or flag irrelevant findings as tolerated or false positives. If you feel that the Teamscale config needs adjustment, please state so in a comment and discuss this with your reviewer.