-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Doc] Remove podman/docker dependency to access internal registry #3225
[Doc] Remove podman/docker dependency to access internal registry #3225
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This also switches from alpine to ubi8, this is not mentioned at all in the commit log.
There was one good thing about the previous example based on podman: this was showing that the openshift registry and regular podman/docker were interoperable, something we lost here.
However, not sure crc's doc are thebest place to showcase/document this :)
This patch uses `oc mirror` command to push image from remote container registry to openshift internal registry and make it available to imagestream. Recently user observed if ubi images are pulled using podman then pushing it to internal registry have signature verification error (containers/podman#14558) for mac/windows. This issue is recently fixed on podman remote clients but still not released so better not to use podman/docker steps just to show user around internal registry usage. It will also change apline to ubi8 image.
7a238ad
to
82db3f6
Compare
Mentioned in the commit log.
I am also not sure may be a different section in the doc around this interaction of podman/docker with cluster? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good to me. I assume they've been tested across the supported platforms, correct?
Also, agreed, we could use a more dedicated section to document interaction between the cluster and Podman.
Yes, they are tested on all the platform. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: anjannath, robin-owen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@robin-owen created https://github.com/code-ready/crc/issues/3227 if you want to look at this |
This patch uses
oc mirror
command to push image from remote containerregistry to openshift internal registry and make it available to
imagestream. Recently user observed if ubi images are pulled using
podman then pushing it to internal registry have signature verification
error (containers/podman#14558) for
mac/windows. This issue is recently fixed on podman remote clients but
still not released so better not to use podman/docker steps just to show
user around internal registry usage.