Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Improve development guide for better getting started experience #6

Open
1 task
rohanKanojia opened this issue Oct 21, 2024 · 1 comment
Open
1 task
Assignees

Comments

@rohanKanojia
Copy link

Component

Development Documentation

Task description

Currently, for a beginner, these documents are sources to get information about the project and how to start developing it:

However, I still see some areas of improvement especially for development docs so that onboarding new developers can be made faster. In my opinion, these sections should be added to the development guide:

  • Preferred IDE for development, any additional configuration required?
  • How to use a development build of CRC?
  • How to run CRC in debug mode?
  • Style conventions used by the project, how to apply them (IDE configuration)?
  • Building the documentation (should be moved from README.adoc to developing.adoc)
  • Commit Conventions (Do we use conventional commits?)

I've taken some points from Eclipse JKube Contributing guide. I think we can add these points to improve onboarding time for newcomers.

Acceptance Criteria

  • Developer getting started guide is improved by addressing the abovementioned points (subject to change as per discussion)
@gbraad
Copy link
Contributor

gbraad commented Oct 22, 2024

I agree we need to update the getting started guide from a development perspective, and I have started to convert some files to markdown (developing.adoc and the wiki), to a new repo. These suggestions will be considered

Preferred IDE for development, any additional configuration required?

I do not think we should 'prefer' an IDE. It is Go, so anything will do. And as on the team, people use Vi, VSCode, Goland, etc. I am more for describing the recommended tools around it, like Go version; how to install. I personally modify the UBI8/9 images to create a development environment that can be remotely used.

Style conventions used by the project, how to apply them (IDE configuration)?

make fmt

Commit Conventions (Do we use conventional commits?)

Gnarly conversation. I think a consensus was reached. But I, especially with the use of Jira, think that we should always refer to an issue in the title and/or description.

@gbraad gbraad self-assigned this Nov 14, 2024
@gbraad gbraad transferred this issue from crc-org/crc Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

2 participants