Skip to content
This repository has been archived by the owner on Jun 2, 2023. It is now read-only.

Lack of progress indication from the console (podman module in Cockpit) when a matching image for the architecture is missing #135

Open
3 tasks
gbraad opened this issue Feb 7, 2022 · 6 comments
Labels
help wanted Extra attention is needed os/linux os/macos

Comments

@gbraad
Copy link
Collaborator

gbraad commented Feb 7, 2022

When a download is started for a container there is no indication of progress.

For instance, we got a report that a download was started multiple times, but never finished. This was due to the fact this was running on aarch64/M1. The arch was not available for the requested image: "no image found in manifest list for architecture arm64, variant "v8", OS linux".

This didn't bubble up for us. This might be due to the fact we are hosting just the frame (without the shell). But this is problematic.


There are actually several issues here:

Discussed with @jelly, but need more info from reporter to reproduce this

@gbraad gbraad added help wanted Extra attention is needed os/linux os/macos labels Feb 7, 2022
@gbraad
Copy link
Collaborator Author

gbraad commented Feb 7, 2022

@martinpitt WDYT?

@gbraad
Copy link
Collaborator Author

gbraad commented Feb 7, 2022

Lack of progress indication is known as: containers/podman#12341

@gbraad gbraad changed the title Lack of progress indication from the console (podman module in Cockpit) Lack of progress indication from the console (podman module in Cockpit) when a matching image for the architecture is missing Feb 7, 2022
@gbraad

This comment was marked as duplicate.

@deboer-tim
Copy link
Contributor

deboer-tim commented Feb 7, 2022

To reproduce just pick an image that doesn't support your OS, e.g. I'm on M1 so something like docker.io/library/ibmjava will fail (no errors, just shows 'downloading' forever). As per @gbraads comments, I'm less concerned with this specific error than the general problem of error reporting and feedback. e.g. this container is added to the list and shows 'downloading' indefinitely, but if I close the console window and reopen it it's gone.

@gbraad
Copy link
Collaborator Author

gbraad commented Feb 8, 2022

I'm less concerned with this specific error

I believe filter should have been applied to prevent this image to show up. I think what happens is that a default is used, the image appears, but the matching arch is not in the results. This should have been prevented by the podman image query itself.

general problem of error reporting and feedback

In the worst case, if this is related to the missing shell framing, I might consider overwriting this with a barebones implementation that at least will show some notifications and perhaps even resort to using:

Notification.requestPermission().then(function(result) {
    ...
});

and

new Notification('CodeReady Containers', {
            body: message,
            icon: "./ocp-logo.png"
        });

to have the same kind of notifications happen. Or it might even allow to use WebContents and window.api use. (Preferred)

@gbraad
Copy link
Collaborator Author

gbraad commented Feb 9, 2022

I'll try to 'hack' the Cockpit shell a little and see if we can instead use a customized wrapper.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
help wanted Extra attention is needed os/linux os/macos
Projects
None yet
Development

No branches or pull requests

2 participants