Download failures of container image not shown

[gbraad]

We are hosting the podman view as a frame, and therefore do not have the shell available to us. This might be the problem, but when ewe download an image that is not actually available for the target #913 we aren't informed of a failure.

Originally posted by @gbraad in crc-org/tray-electron#135 (comment)

[jelly]

What do you mean with frame and shell? I think the notifications are drawn inside cockpit-podman so not something cockpit itself provides.

No shell means http://${podmanHost}:9090/cockpit/@localhost/podman/index.html

[gbraad]

We open a single module as the cockpit-desktop *1 *2 would do

http://${podmanHost}:9090/cockpit/@localhost/podman/index.html

https://github.com/code-ready/tray-electron/blob/057a3bae9f1d9a8ebb2fe01adc72e74bfb254549/main.js#L847

This means we do not host shell with the navigation, etc

no shell => https://github.com/cockpit-project/cockpit/tree/main/pkg/shell

[jelly]

Just setup my RPI with Fedora server, creating a new container and selecting archlinux which has no AARCH64 image and it is indeed stuck at showing "Downloading".

podman ps and podman ps -a shows nothing. Ideally we would filter valid images up front but I'm afraid we lack the information to do so.

[jelle@fedora ~]$ podman pull archlinux
✔ docker.io/library/archlinux:latest
Trying to pull docker.io/library/archlinux:latest...
Error: choosing an image from manifest list docker://archlinux:latest: no image found in manifest list for architecture arm64, variant "v8", OS linux
[jelle@fedora ~]$ 

[jelle@fedora ~]$ curl -X POST -s -g --no-buffer --unix-socket /run/user/1000/podman/podman.sock 'http://localhost/v1.12/libpod/images/pull?reference=docker.io/archlinux'
{"stream":"Trying to pull docker.io/library/archlinux:latest...\n"}
{"error":"choosing an image from manifest list docker://archlinux:latest: no image found in manifest list for architecture arm64, variant \"v8\", OS linux"}

There is an error shown which we don't handle.

[gbraad]

In this case, will the download now show an error or just 'finish' downloading?

[jelly]

In this case, will the download now show an error or just 'finish' downloading?

It does, but hmm this is something we should improve!

[jelly]

As podman doesn't give error codes, this is the best we can do:

Fixed in #916 should be in the release next week.

[gbraad]

OK, better than nothing. But very UI unfriendly

[jelly]

OK, better than nothing. But very UI unfriendly

I agree, I hope podman can implement optional filtering of architecture then we can use that in cockpit-podman

[vrothberg]

Note that I currently do not have time to implement it but the summary here should give a good starting point on what needs to be done. Again the warning that such client-side filtering can be very slow/expensive. Unfortunately, the search endpoints on registries do not support such filters.