Skip to content

Commit

Permalink
Call the correct function on error
Browse files Browse the repository at this point in the history
In 7b29541 we introduced the 'pull latest image' option which changed
the onDownloadContainerFinished function but the pullImage's catch
wasn't updated. Causing the download to stay forever when it fails and
no error message being shown.

Closes cockpit-project#914
  • Loading branch information
jelly committed Feb 10, 2022
1 parent cfc4536 commit b2f3ed9
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/ImageRunModal.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -511,7 +511,7 @@ export class ImageRunModal extends React.Component {
});
})
.catch(ex => {
this.props.onDownloadContainerFinished(createConfig);
onDownloadContainerFinished(createConfig);
const error = cockpit.format(_("Failed to pull image $0"), tempImage.image);
this.props.onAddNotification({ type: 'danger', error, errorDetail: ex.reason });
});
Expand Down

0 comments on commit b2f3ed9

Please sign in to comment.