-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support callback request subscribers and job notification refactoring #572
Conversation
…ation_email + refactor job notification logic
Codecov Report
@@ Coverage Diff @@
## master #572 +/- ##
==========================================
+ Coverage 84.71% 84.87% +0.16%
==========================================
Files 79 79
Lines 17828 17910 +82
Branches 2708 2716 +8
==========================================
+ Hits 15103 15202 +99
+ Misses 1992 1980 -12
+ Partials 733 728 -5
|
…lient + fix logging issue in CLI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well with Finch!
( using notification_email)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor fixes on outputs/comments/variable names, the rest looks good to me.
Good job!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, if I understood this correctly, multiple subscribers are only supported for different job status. Do you think it could be interesting to allow multiple emails notification for each status ?
Yes
Could be, but I think we can work around it with a mailing list for the moment without changing the code. |
c56b512
to
2978ef7
Compare
Changes
Job
subscribers
support to defineOGC
-compliant callback URLs where HTTP(S) requests will be sent uponreaching certain
Job
status milestones (fixes [Feature] Support and validate Job notification callback URL #230).subscribers
definition (extension overOGC
minimal requirements).Job
notification_email
in theOpenAPI
specification in favor ofsubscribers
, but preserveparsing of its value if provided in the
JSON
body duringJob
submission for backward compatibility support ofexisting servers. The
Job.notification_email
attribute is removed to avoid duplicate references.Job
started
status, only available through thesubscribers
property.{PROCESS_ID}/{STATUS}.mako
template detection under theweaver.wps_email_notify_template_dir
locationto allow per-
Process
and per-Job
status email customization.weaver/notify.py
andweaver/processes/execution.py
to avoid mixed references to theencryption/decryption logic employed for notification emails. All notifications including emails and
callback requests are now completely handled and contained in the
weaver/notify.py
module.References