Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add test to detect celery/pyramid-registry problematic resolution #590

Merged
merged 18 commits into from
Nov 22, 2023

Conversation

fmigneault
Copy link
Collaborator

@fmigneault fmigneault commented Nov 16, 2023

To Do

  • patch get_registry and relevant methods such that test succeeds
  • validate against running / live server where issue was observed (@perronld)
  • extend test for more cases if not resolved entirely
  • update changelog

References

@fmigneault fmigneault requested a review from perronld November 16, 2023 05:11
@fmigneault fmigneault self-assigned this Nov 16, 2023
@github-actions github-actions bot added ci/tests Tests of the package and features ci/doc Issue related to documentation of the package labels Nov 16, 2023
@fmigneault
Copy link
Collaborator Author

@perronld Just need a counter validation to make sure I didn't reintroduce the problem.

perronld
perronld previously approved these changes Nov 21, 2023
Copy link
Contributor

@perronld perronld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in staging, works perfectly!

perronld
perronld previously approved these changes Nov 21, 2023
@github-actions github-actions bot added feature/db Related to database or datatype manipulation. process/workflow Related to a Workflow process. labels Nov 22, 2023
Copy link

codecov bot commented Nov 22, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (2752c63) 85.17% compared to head (bb8cdb4) 85.17%.

Files Patch % Lines
weaver/__init__.py 0.00% 2 Missing ⚠️
weaver/utils.py 81.81% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #590   +/-   ##
=======================================
  Coverage   85.17%   85.17%           
=======================================
  Files          79       79           
  Lines       18023    18035   +12     
  Branches     2728     2731    +3     
=======================================
+ Hits        15351    15362   +11     
- Misses       1941     1942    +1     
  Partials      731      731           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fmigneault fmigneault merged commit c6d1700 into master Nov 22, 2023
42 of 47 checks passed
@fmigneault fmigneault deleted the test-celery-registry-setup branch November 22, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/doc Issue related to documentation of the package ci/tests Tests of the package and features feature/db Related to database or datatype manipulation. process/workflow Related to a Workflow process.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants