Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set default value for enums with a UNSPECIFIED option #15

Merged
merged 2 commits into from
Jul 1, 2024
Merged

set default value for enums with a UNSPECIFIED option #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
78249aa
Add default value to severity
Avarei Jun 29, 2024
b28727e
add default for resource readiness
Avarei Jul 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkl/crossplane.contrib/CompositionResponse.pkl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ class ResponseMeta {
/// A Result of running a Function.
class Result {
/// Severity of this result.
severity: Severity
severity: Severity = SEVERITY_UNSPECIFIED

/// Human-readable details about the result.
message: String
Expand Down
2 changes: 1 addition & 1 deletion pkl/crossplane.contrib/Resource.pkl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ typealias Ready = Int(isBetween(0,2))
///
/// - A Function should not set this field in a RunFunctionResponse to indicate
/// that the desired composite resource is ready. This will be ignored.
ready: Ready?
ready: Ready? = READY_UNSPECIFIED

/// The resource's connection details.
///
Expand Down