Skip to content

Commit

Permalink
Removed the setExternalName from postCreate
Browse files Browse the repository at this point in the history
Signed-off-by: Domene Esteban, Nil {DISB~SANT CUGAT DIA} <[email protected]>
  • Loading branch information
nilde committed Oct 10, 2023
1 parent 16673d5 commit ab907bf
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion pkg/controller/kinesis/stream/setup.go
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,10 @@ func SetupStream(mgr ctrl.Manager, o controller.Options) error {

reconcilerOpts := []managed.ReconcilerOption{
managed.WithExternalConnecter(&connector{kube: mgr.GetClient(), opts: opts}),
managed.WithReferenceResolver(managed.NewAPISimpleReferenceResolver(mgr.GetClient())),
managed.WithInitializers(
managed.NewDefaultProviderConfig(mgr.GetClient()),
managed.NewNameAsExternalName(mgr.GetClient())),
managed.WithPollInterval(o.PollInterval),
managed.WithLogger(o.Logger.WithValues("controller", name)),
managed.WithRecorder(event.NewAPIRecorder(mgr.GetEventRecorderFor(name))),
Expand Down Expand Up @@ -124,7 +128,6 @@ func postCreate(_ context.Context, cr *svcapitypes.Stream, obj *svcsdk.CreateStr
if err != nil {
return managed.ExternalCreation{}, err
}
meta.SetExternalName(cr, *awsclients.String(meta.GetExternalName(cr)))
return managed.ExternalCreation{ExternalNameAssigned: true}, nil
}

Expand Down

0 comments on commit ab907bf

Please sign in to comment.