-
Notifications
You must be signed in to change notification settings - Fork 376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cannot modify RDS instance: api error InvalidParameterCombination: No modifications were requested #1795
cannot modify RDS instance: api error InvalidParameterCombination: No modifications were requested #1795
Comments
@mateusz-lubanski-sinch can you provide a sample MR to reproduce this issue? |
Hey @MisterMX Below is example of MR which is in
|
We are seeing a similar behavior with the field here the request from Cloudtrail:
As already mentioned in the issue, changing
also visible in the MR events:
with the bit debugging I have done in the controller so far, my evaluation:
I probably will try to fix this in the next days. |
Hey @wotolom & @MisterMX current provider
ManagedResource state:
AWS CloudTrail Log:
crossplane version |
ahh I see, thanks a lot for that fix! <3 |
sorry for my previous (wrong and now deleted) comment, that fix coming with provider-aws v0.43.0 is similar, but applies to another field ( You are actually right with expecting the fix for I just tested this, but for me it seems to work fine in provider-aws v0.42.0:
Also the case where the
|
I can share my
Above ManagedResource was not changed before or after provider-aws upgrade to |
Thanks that helped! The I will provide a small fix that ignored @mateusz-lubanski-sinch if you can change the |
I updated kmsKey (replaced id with arn) but still in events I can see:
|
Could you please check, if the behavior stays identical after you upgrade to provider-aws v0.43.0? If it does, please look into the provider-aws (pod) logs and search for logs concerning the specific rdsinstance. Try to find the log message that includes the observed diff. (it contains the following string: provider-aws/pkg/clients/database/rds.go Line 725 in d5f6675
|
I am still getting same event with
Should I enable debug logs to see that message?
|
@wotolom should I create new issue or should we re-open this one? |
I think it is best to create a new issue, because for me it looks like same error message but different underlying error source. |
Our RDSInstance get into an SYNCED=False status with below event:
when I look into AWS CloudTrail I found request done by crossplane:
optionG
When I set
applyImmedietely
totrue
it changes status to True but no changes are performed. This is on our production environment so we don't want set by defaultapplyImmedietely
totrue
After setting
applyImmedietely
back tofalse
I am getting again same Warning eventCrossplane version:
1.12.1
xpkg.upbound.io/crossplane-contrib/provider-aws:v0.40.0
AWS
The text was updated successfully, but these errors were encountered: