fix(rdsinstance): ignore KMSKeyID in IsUpToDate + lateinit OptionGrou… #1856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MisterMX
reviewed
Aug 31, 2023
wotolom
force-pushed
the
fix-rdsinstance-immutable-kmskeyid
branch
from
cb8aa38 to
578394b
Compare
…pName Signed-off-by: Charel Baum (external expert on behalf of DB Netz AG) <[email protected]>
wotolom
force-pushed
the
fix-rdsinstance-immutable-kmskeyid
branch
from
578394b to
36dbee6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
for
database.RDSInstanceKMSKeyIDinIsUpToDate(), because the parameter is immutable (see https://docs.aws.amazon.com/cli/latest/reference/rds/modify-db-instance.html)OptionGroupName(partly for cleaner patch generation)Fixes #1795 (comment)
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
manually