feat(globalaccelerator): Add support for accelerator, listener and endpointgroups #1820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaessert
force-pushed
the
atarax/globalaccelerator
branch
2 times, most recently
from
0193bb5 to
0b399ff
Compare
kaessert
force-pushed
the
atarax/globalaccelerator
branch
from
0b399ff to
f1e1d07
Compare
kaessert
force-pushed
the
atarax/globalaccelerator
branch
2 times, most recently
from
eae6cc0 to
a25c059
Compare
…dpointgroups Signed-off-by: cite <[email protected]>
kaessert
force-pushed
the
atarax/globalaccelerator
branch
from
a25c059 to
5d59c21
Compare
|
@MisterMX Sure, done :) |
|
Always a pleasure :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Introduces support for accelerator, listener and endpointgroups.
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Code so far only has been tested on a local kind cluster. Accelerator and Listener have been manually tested for creation, deletion and updates. Endpointgroup so far has only been tested for creation and deletion.
I could add some unit-tests too. If someone might be able to give me a pointer to a simple example how this is done i would be very happy and it would shorten the time.
Open issues
For deletion of an accelerator, all listeners need to be deleted and it has to be in disabled state. I didn't find a way to temporarily skip the delete in the case of the accelerator just being disabled, which results in some error but eventually reconciles.