feat: expose metrics for all AWS API calls #1862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MisterMX
requested changes
Sep 5, 2023
There was a problem hiding this comment.
Thank you very much for your contribution, @threadproc! I think including AWS metric would a very meaningful enhancement.
I have made some small remarks that would need to be solved before merging. Can you take a look at them?
threadproc
force-pushed
the
feature/aws-api-call-metrics
branch
from
d281921 to
9acbf87
Compare
|
@MisterMX I've made the requested changes and resolved some linting errors as well, thanks for the review! |
|
Great, very nice that you found a way to two this via hooks in the SDK! |
MisterMX
requested changes
Sep 6, 2023
Signed-off-by: Kai Parry <[email protected]>
threadproc
force-pushed
the
feature/aws-api-call-metrics
branch
from
9acbf87 to
27686ee
Compare
|
@MisterMX I've implemented the requested changes and squashed them down again, thank you! |
MisterMX
approved these changes
Sep 6, 2023
There was a problem hiding this comment.
LGTM. Thank you very much for your contribution @threadproc!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This change will add a new Prometheus metric,
aws_api_calls_total, exposed by controller-runtime that counts all requests made to the AWS APIs. This is useful when using expensive APIs like the Service Catalog API ($0.0007/request) for accounting purposes on accounts with multiple clusters.I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
This has been built and deployed to a test cluster where it was successfully observed to cause no errors when calling either v1 or v2 SDK methods, and successfully included the new metric on the
/metricsendpoint.