-
Notifications
You must be signed in to change notification settings - Fork 376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update build system #1888
chore: Update build system #1888
Conversation
golangci/golangci-lint-action#23 (comment) I think we need to rewrite the lint action The reference code from README.md is just https://github.com/golangci/golangci-lint-action#golangci-lint-action
|
1553f5a
to
63b2a1c
Compare
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
e4220e4
to
780565f
Compare
I extended this PR with the following:
@chlunde can you check again? |
.github/workflows/ci.yml
Outdated
@@ -259,43 +324,53 @@ jobs: | |||
if: needs.detect-noop.outputs.noop != 'true' | |||
|
|||
steps: | |||
- name: Cleanup Disk | |||
uses: jlumbroso/free-disk-space@main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pin this? Doubly so because I have not heard of it :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, makes sense. Thanks for pointing that one out 👍
* Use Go v1.21.2 ** Add ignore opts to some tests because they failed due to the unexported context.backgroundCtx struct * Bump golangci-lint to v1.54.0 * Bump build submodule Copy (most of) .golancilint.yml from github.com/crossplane/crossplane and fix the linter issues accordingly. Go import order is now 1. Go standard packages 2. 3rd party packages 3. local packages Signed-off-by: Maximilian Blatt (external expert on behalf of DB Netz) <[email protected]> Co-authored-by: ivan katliarchuk <[email protected]>
780565f
to
5e2d8dd
Compare
Description of your changes
Bump golangci-lint to v1.54.0
Superseedes #1859
I have:
make reviewable test
to ensure this PR is ready for review.How has this code been tested